Re: [PATCH 3/6] dt-bindings: mtu3: add devicetree bindings

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/6] dt-bindings: mtu3: add devicetree bindings
Date	2016-05-13 05:10 +0200
Message-ID	<rybEd-2Qe-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <rxbdg-76W-13@gated-at.bofh.it> <rxDMf-1Nm-31@gated-at.bofh.it> <rxTeh-WJ-3@gated-at.bofh.it> <ry7TX-7Gm-3@gated-at.bofh.it> <ryaI9-1Ok-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 12, 2016 at 9:00 PM, chunfeng yun <chunfeng.yun@mediatek.com> wrote:
> Hi,
>
> On Thu, 2016-05-12 at 19:02 -0400, Alan Cooper wrote:
>> On Thu, May 12, 2016 at 3:24 AM, chunfeng yun <chunfeng.yun@mediatek.com> wrote:
>> >> > + - mediatek,enable-manual-drd : supports manual dual-role switch by sysfs
>> >> > +   interface; only used when receptacle is TYPE-A and also wants to support
>> >> > +   dual-role mode.
>> >>
>> >> sysfs is a Linux detail that doesn't apply to the binding. Does the
>> >> property mean "the IP block supports or doesn't support switching"  or
>> >> "I want to enable switching feature". Only the former belongs in DT.
>> >>
>> > It is the former case, and has little relation with sysfs interface.
>> > I will modify it later, sorry for my unclear description.
>>
>> Could the property name be just "enable-manual-drd" instead of
>> "mediatek,enable-manual-drd"? I expect to have to add this
>> functionality to our USB driver in the near future.
>
> Do you mean provide some APIs to in common USB driver?

Probably, but first just put the property in a common binding doc.

Rob

Thread

[PATCH 3/6] dt-bindings: mtu3: add devicetree bindings Chunfeng Yun <chunfeng.yun@mediatek.com> - 2016-05-10 10:30 +0200
  Re: [PATCH 3/6] dt-bindings: mtu3: add devicetree bindings Rob Herring <robh@kernel.org> - 2016-05-11 17:00 +0200
    Re: [PATCH 3/6] dt-bindings: mtu3: add devicetree bindings chunfeng yun <chunfeng.yun@mediatek.com> - 2016-05-12 09:30 +0200
      Re: [PATCH 3/6] dt-bindings: mtu3: add devicetree bindings Alan Cooper <alcooperx@gmail.com> - 2016-05-13 01:10 +0200
        Re: [PATCH 3/6] dt-bindings: mtu3: add devicetree bindings chunfeng yun <chunfeng.yun@mediatek.com> - 2016-05-13 04:10 +0200
          Re: [PATCH 3/6] dt-bindings: mtu3: add devicetree bindings Rob Herring <robh@kernel.org> - 2016-05-13 05:10 +0200
            Re: [PATCH 3/6] dt-bindings: mtu3: add devicetree bindings chunfeng yun <chunfeng.yun@mediatek.com> - 2016-05-13 05:20 +0200

csiph-web