Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1400444

Re: [PATCH v4 10/18] sh: Remove unnecessary of_platform_populate with default match table

Show all headers | View raw

On 2016/5/13 2:38, Rich Felker wrote:
> On Thu, May 12, 2016 at 08:06:07PM +0800, Kefeng Wang wrote:
>> After patch "of/platform: Add common method to populate default bus",
>> it is possible for arch code to remove unnecessary callers about the
>> of_platform_populate with default match table.
> 
> s/about the/of/ ?

Ok, will update.

> 
>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>> Cc: Rich Felker <dalias@libc.org>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>  arch/sh/boards/of-generic.c | 14 --------------
>>  1 file changed, 14 deletions(-)
>>
>> diff --git a/arch/sh/boards/of-generic.c b/arch/sh/boards/of-generic.c
>> index b4d4313..911ffb9 100644
>> --- a/arch/sh/boards/of-generic.c
>> +++ b/arch/sh/boards/of-generic.c
>> @@ -9,7 +9,6 @@
>>   */
>>  
>>  #include <linux/of.h>
>> -#include <linux/of_platform.h>
>>  #include <linux/of_fdt.h>
>>  #include <linux/clocksource.h>
>>  #include <linux/irqchip.h>
>> @@ -179,16 +178,3 @@ void __init arch_init_clk_ops(struct sh_clk_ops **ops, int idx)
>>  void __init plat_irq_setup(void)
>>  {
>>  }
>> -
>> -static int __init sh_of_device_init(void)
>> -{
>> -	pr_info("SH generic board support: populating platform devices\n");
>> -	if (of_have_populated_dt()) {
>> -		of_platform_populate(NULL, of_default_bus_match_table,
>> -				     NULL, NULL);
>> -	} else {
>> -		pr_crit("Device tree not populated\n");
>> -	}
>> -	return 0;
>> -}
>> -arch_initcall_sync(sh_of_device_init);
>> -- 
>> 1.7.12.4
> 
> I have not tested this, but as long as the new arch-generic code takes
> place at the same point in the init sequence (arch_initcall_sync), as
> it seems to, I don't expect any sh-specific breakage. In general I'm
> happy to see this kind of change.

Hope no breakage in all archs, but I can only test this in few arm/arm64 boards :(

Thanks,
Kefeng

> 
> Rich
> 
> .
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 00/18] Cleanup for populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-05-12 14:10 +0200
  [PATCH v4 02/18] arc: Remove unnecessary of_platform_populate with default match table Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-05-12 14:10 +0200
    Re: [PATCH v4 02/18] arc: Remove unnecessary of_platform_populate  with default match table Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-05-13 05:10 +0200
  [PATCH v4 17/18] of: unittest: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-05-12 14:10 +0200
  [PATCH v4 06/18] cris: Remove unnecessary of_platform_populate with default match table Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-05-12 14:10 +0200
    Re: [PATCH v4 06/18] cris: Remove unnecessary of_platform_populate  with default match table Jesper Nilsson <jesper.nilsson@axis.com> - 2016-05-16 10:10 +0200
  [PATCH v4 12/18] arm: use of_platform_default_populate() to populate Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-05-12 14:10 +0200
    Re: [PATCH v4 12/18] arm: use of_platform_default_populate() to  populate Viresh Kumar <viresh.kumar@linaro.org> - 2016-05-13 05:00 +0200
    Re: [PATCH v4 12/18] arm: use of_platform_default_populate() to  populate Sekhar Nori <nsekhar@ti.com> - 2016-05-17 10:10 +0200
    Re: [PATCH v4 12/18] arm: use of_platform_default_populate() to  populate Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-05-17 11:20 +0200
  [PATCH v4 05/18] c6x: Remove unnecessary of_platform_populate with default match table Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-05-12 14:10 +0200
  [PATCH v4 10/18] sh: Remove unnecessary of_platform_populate with default match table Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-05-12 14:10 +0200
    Re: [PATCH v4 10/18] sh: Remove unnecessary of_platform_populate  with default match table Rich Felker <dalias@libc.org> - 2016-05-12 20:50 +0200
      Re: [PATCH v4 10/18] sh: Remove unnecessary of_platform_populate with  default match table Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-05-13 03:50 +0200
  [PATCH v4 07/18] metag: Remove unnecessary of_platform_populate with default match table Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-05-12 14:10 +0200

csiph-web