Re: [PATCH] iommu/rockchip: fix zap cache during device attach

From	Heiko Stuebner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iommu/rockchip: fix zap cache during device attach
Date	2016-05-14 22:30 +0200
Message-ID	<ryOme-7YR-17@gated-at.bofh.it> (permalink)
References	<rxieL-5nU-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Dienstag, 10. Mai 2016, 16:50:46 schrieb John Keeping:
> rk_iommu_command() takes a struct rk_iommu and iterates over the slave
> MMUs, so this is doubly wrong in that we're passing in the wrong pointer
> and talking to MMUs that we shouldn't be.
> 
> Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi
> slaves") Signed-off-by: John Keeping <john@metanate.com>

on a rk3288-veyron
Tested-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>

I was wondering for a short time why this didn't spew warnings until I 
realized that the iommu->bases[i] is of course a void* .


Heiko

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] iommu/rockchip: fix zap cache during device attach Heiko Stuebner <heiko@sntech.de> - 2016-05-14 22:30 +0200
  Re: [PATCH] iommu/rockchip: fix zap cache during device attach John Keeping <john@metanate.com> - 2016-05-16 04:10 +0200

csiph-web