Re: [PATCH] watchdog: remove error message when unable to allocate watchdog device

From	Wim Van Sebroeck <wim@iguana.be>
Newsgroups	linux.kernel
Subject	Re: [PATCH] watchdog: remove error message when unable to allocate watchdog device
Date	2016-05-14 20:40 +0200
Message-ID	<ryMDM-6cI-15@gated-at.bofh.it> (permalink)
References	<rseOu-2Z1-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Colin,

> From: Colin Ian King <colin.king@canonical.com>
> 
> The dev_err message is superfluous because the failure is already
> printed by dev_kzalloc, so remove it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/watchdog/jz4740_wdt.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
> index 6a7d5c3..c8d51dd 100644
> --- a/drivers/watchdog/jz4740_wdt.c
> +++ b/drivers/watchdog/jz4740_wdt.c
> @@ -160,10 +160,8 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
>  
>  	drvdata = devm_kzalloc(&pdev->dev, sizeof(struct jz4740_wdt_drvdata),
>  			       GFP_KERNEL);
> -	if (!drvdata) {
> -		dev_err(&pdev->dev, "Unable to alloacate watchdog device\n");
> +	if (!drvdata)
>  		return -ENOMEM;
> -	}
>  
>  	if (heartbeat < 1 || heartbeat > MAX_HEARTBEAT)
>  		heartbeat = DEFAULT_HEARTBEAT;
> -- 
> 2.7.4
> 

This patch was added to linux-watchdog-next.

Kind Regards,
Wim.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] watchdog: remove error message when unable to allocate watchdog device Wim Van Sebroeck <wim@iguana.be> - 2016-05-14 20:40 +0200

csiph-web