Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401133

Re: [PATCH 1/2] watchdog: cpwd: Use setup_timer()

Show all headers | View raw

Hi Muhammed,

> The function setup_timer combines the initialization of a timer with
> the initialization of the timer's function and data fields.
> The multiline code for timer initialization is now replaced
> with function setup_timer.
> 
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
>  drivers/watchdog/cpwd.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c
> index 0200768..71ee079 100644
> --- a/drivers/watchdog/cpwd.c
> +++ b/drivers/watchdog/cpwd.c
> @@ -611,9 +611,7 @@ static int cpwd_probe(struct platform_device *op)
>  	}
>  
>  	if (p->broken) {
> -		init_timer(&cpwd_timer);
> -		cpwd_timer.function	= cpwd_brokentimer;
> -		cpwd_timer.data		= (unsigned long) p;
> +		setup_timer(&cpwd_timer, cpwd_brokentimer, (unsigned long)p);
>  		cpwd_timer.expires	= WD_BTIMEOUT;
>  
>  		pr_info("PLD defect workaround enabled for model %s\n",
> -- 
> 1.9.1
> 

This patch was added to linux-watchdog-next.

Kind Regards,
Wim.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] watchdog: cpwd: Use setup_timer() Wim Van Sebroeck <wim@iguana.be> - 2016-05-14 20:40 +0200

csiph-web