Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1401110

Re: [PATCH] sp5100_tco: properly check for new register layouts

From Wim Van Sebroeck <wim@iguana.be>
Newsgroups linux.kernel
Subject Re: [PATCH] sp5100_tco: properly check for new register layouts
Date 2016-05-14 18:50 +0200
Message-ID <ryKVj-49j-11@gated-at.bofh.it> (permalink)
References <ruM9k-3Bx-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Lucas,

> Commits 190aa4304de6 (Add AMD Mullins platform support) and
> cca118fa2a0a94 (Add AMD Carrizo platform support) enabled the
> driver on a lot more devices, but the following commit missed
> a single location in the code when checking if the SB800 register
> offsets should be used. This leads to the wrong register being
> written which in turn causes ACPI to go haywire.
> 
> Fix this by introducing a helper function to check for the new
> register layout and use this consistently.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=114201
> https://bugzilla.redhat.com/show_bug.cgi?id=1329910
> Fixes: bdecfcdb5461 (sp5100_tco: fix the device check for SB800
> and later chipsets)
> Cc: stable@vger.kernel.org (4.5+)
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
>  drivers/watchdog/sp5100_tco.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 

This patch has been added to linux-watchdog-next.

Kind regards,
Wim.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] sp5100_tco: properly check for new register layouts Wim Van Sebroeck <wim@iguana.be> - 2016-05-14 18:50 +0200

csiph-web