Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401094

Re: [RFC PATCH 0/3] Amlogic: GXBB: Add reset controller

Show all headers | View raw

Hi Neil,

Neil Armstrong <narmstrong@baylibre.com> writes:

> Patchset to add and enable the reset controller driver on GXBB platforms.

Looking closer at the vendor BSP reset driver, I realized that that
kernel doesn't seem to be using this reset IP at all.  Their reset
driver is actually just using clock gating in the HHI_GCLK_MPEGx
registers.

I'm not sure I understand why they made that choice (I've asked
off-list), but we'll need to keep in mind that any usage of the reset
driver in the vendor DTs corresponds do clock gating, and not this reset
IP.

In any case, other than the minor comments, this looks like a good
driver for the reset IP in the S905/GXBB.

Also, I gave this driver a quick test with the network driver support I
recently posted.  When the network driver is loaded, it deasserts the
reset and when unloaded, it asserts the reset.  Interestingly, the
assert cases a full system lockup. :(

I've asked some Amlogic folks off-list about this issue too, and hope to
get some more clarifcation (and ideally docs) about this reset IP soon.

Kevin

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/3] Amlogic: GXBB: Add reset controller Neil Armstrong <narmstrong@baylibre.com> - 2016-05-13 16:10 +0200
  Re: [RFC PATCH 0/3] Amlogic: GXBB: Add reset controller Kevin Hilman <khilman@baylibre.com> - 2016-05-14 17:20 +0200
  Re: [RFC PATCH 0/3] Amlogic: GXBB: Add reset controller Kevin Hilman <khilman@baylibre.com> - 2016-05-14 17:20 +0200

csiph-web