[PATCH 1/2] f2fs: fix i_current_depth during inline dentry conversion

Path	csiph.com!usenet.blueworldhosting.com!feeder01.blueworldhosting.com!news.glorb.com!bofh.it!news.nic.it!robomod
From	Chao Yu <yuchao0@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] f2fs: fix i_current_depth during inline dentry conversion
Date	Sat, 14 May 2016 13:10:01 +0200
Message-ID	<ryFCh-7WC-1@gated-at.bofh.it> (permalink)
X-Original-To	<jaegeuk@kernel.org>
X-Mailer	git-send-email 2.8.2.311.gee88674
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[10.120.216.130]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A020204.57370626.01C1,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	c49fe36fa3a845f692293d56db64f779
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-f2fs-devel@lists.sourceforge.net>, <linux-kernel@vger.kernel.org>, Chao Yu <yuchao0@huawei.com>
X-Original-Date	Sat, 14 May 2016 19:03:52 +0800
X-Original-Message-ID	<20160514110353.31981-1-yuchao0@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1401082

Show key headers only | View raw

With below steps, we will see that dentry page becoming unaccessable later.
This is because we forget updating i_current_depth in inode during inline
dentry conversion, after that, once we failed at somewhere, it will leave
i_current_depth as 0 in non-inline directory. Then, during ->lookup, the
current_depth value makes all dentry pages in first level invisible. Fix
it.

1) mount f2fs with inline_dentry option
2) mkdir dir
3) touch 180 files named [0-179] in dir
4) touch 180 in dir (fail after inline dir conversion)
5) ll dir

ls: cannot access /mnt/f2fs/dir/0: No such file or directory
ls: cannot access /mnt/f2fs/dir/1: No such file or directory
ls: cannot access /mnt/f2fs/dir/2: No such file or directory
ls: cannot access /mnt/f2fs/dir/3: No such file or directory
ls: cannot access /mnt/f2fs/dir/4: No such file or directory

drwxr-xr-x 2 root root 4096  may 13 21:47 ./
drwxr-xr-x 3 root root 4096  may 13 21:46 ../
-????????? ? ?    ?       ?             ? 0
-????????? ? ?    ?       ?             ? 1
-????????? ? ?    ?       ?             ? 10
-????????? ? ?    ?       ?             ? 100
-????????? ? ?    ?       ?             ? 101
-????????? ? ?    ?       ?             ? 102

Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/inline.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 8a51955..60ba7ac 100644
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -400,6 +400,7 @@ static int f2fs_move_inline_dirents(struct inode *dir, struct page *ipage,
 	stat_dec_inline_dir(dir);
 	clear_inode_flag(F2FS_I(dir), FI_INLINE_DENTRY);
 
+	F2FS_I(dir)->i_current_depth = 1;
 	if (i_size_read(dir) < PAGE_SIZE) {
 		i_size_write(dir, PAGE_SIZE);
 		set_inode_flag(F2FS_I(dir), FI_UPDATE_DIR);
-- 
2.8.2.311.gee88674

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] f2fs: fix i_current_depth during inline dentry conversion Chao Yu <yuchao0@huawei.com> - 2016-05-14 13:10 +0200
  [PATCH 2/2] f2fs: fix incorrect error path handling in f2fs_move_rehashed_dirents Chao Yu <yuchao0@huawei.com> - 2016-05-14 13:10 +0200

csiph-web