SHA1-MB algorithm broken on latest kernel

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Megha Dey <megha.dey@linux.intel.com>
Newsgroups	linux.kernel
Subject	SHA1-MB algorithm broken on latest kernel
Date	Fri, 13 May 2016 01:30:02 +0200
Message-ID	<ry8dk-7SC-3@gated-at.bofh.it> (permalink)
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.24,611,1455004800"; d="scan'208";a="978980639"
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.10.4-0ubuntu2
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 12 May 2016 16:31:06 -0700
X-Original-Message-ID	<1463095866.2594.8.camel@megha-Z97X-UD7-TH>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1400417

Show key headers only | View raw

Hi,
 
When booting latest kernel with the CONFIG_CRYPTO_SHA1_MB enabled, I
observe a panic.
 
After having a quick look, on reverting the following patches, I am able
to complete the booting process.
aec4d0e301f17bb143341c82cc44685b8af0b945
8691ccd764f9ecc69a6812dfe76214c86ac9ba06
68874ac3304ade7ed5ebb12af00d6b9bbbca0a16
 
Of the 3 patches, aec4d0e301f17bb143341c82cc44685b8af0b945 seems wrong.
The r10 to r15 registers are used in sha1_x8_avx2.S, which is called
from sha1_mb_mgr_flush_avx2.S.
 
I do not think the functionality of the SHA1-MB crypto algorithm has
been tested after applying these changes. (I am not sure if any of the
other crypto algorithms have been affected by these changes).
 
Thanks,
Megha

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

SHA1-MB algorithm broken on latest kernel Megha Dey <megha.dey@linux.intel.com> - 2016-05-13 01:30 +0200
  Re: SHA1-MB algorithm broken on latest kernel Herbert Xu <herbert@gondor.apana.org.au> - 2016-05-13 05:20 +0200
    Re: SHA1-MB algorithm broken on latest kernel Ingo Molnar <mingo@kernel.org> - 2016-05-13 08:00 +0200
      Re: SHA1-MB algorithm broken on latest kernel Megha Dey <megha.dey@linux.intel.com> - 2016-05-13 19:30 +0200
        Re: SHA1-MB algorithm broken on latest kernel Josh Poimboeuf <jpoimboe@redhat.com> - 2016-05-16 16:50 +0200
          Re: SHA1-MB algorithm broken on latest kernel Megha Dey <megha.dey@linux.intel.com> - 2016-05-16 20:30 +0200
            [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C function ABI Josh Poimboeuf <jpoimboe@redhat.com> - 2016-05-16 22:20 +0200
              Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C  function ABI Megha Dey <megha.dey@linux.intel.com> - 2016-05-16 23:40 +0200
                Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C  function ABI Josh Poimboeuf <jpoimboe@redhat.com> - 2016-05-16 23:50 +0200
                Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C  function ABI Megha Dey <megha.dey@linux.intel.com> - 2016-05-17 01:10 +0200
                Re: [PATCH] crypto/sha1-mb: make sha1_x8_avx2() conform to C  function ABI Herbert Xu <herbert@gondor.apana.org.au> - 2016-05-17 08:40 +0200

csiph-web