Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1400406

Re: [PATCH v3] mmc: dw_mmc: rockchip: Set the drive phase properly

Show all headers | View raw

Am Donnerstag, 12. Mai 2016, 11:31:50 schrieb Douglas Anderson:

[...]

> In commit 7a03fe6f48f3 ("clk: rockchip: reset init state before mmc card
> initialization") we actually started setting this explicitly in the
> kernel, but that commit wasn't quite right and also wasn't quite
> enough.  See <https://patchwork.kernel.org/patch/9085311/> for some
> details.
> 
> Let's explicitly set this phase in dw_mmc.

[...]

> Fixes: 7a03fe6f48f3 ("clk: rockchip: reset init state before mmc card
> initialization") Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

I've tested this patch together with the two clock patches linked above on a 
rk3288-firefly and a rk3288-veyron-jerry. On the firefly tuning still does not 
work (probably really some regulator issue) and on veyron tuning still works 
as expected, so

Tested-by: Heiko Stuebner <heiko@sntech.de>

Doug's explanations both in the commit message and the code look sane to me, 
but I don't feel confident enough in my understanding of the matter to 
transform that into a Reviewed-by tag.


Heiko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] mmc: dw_mmc: rockchip: Set the drive phase properly Douglas Anderson <dianders@chromium.org> - 2016-05-12 20:40 +0200
  Re: [PATCH v3] mmc: dw_mmc: rockchip: Set the drive phase properly Heiko Stuebner <heiko@sntech.de> - 2016-05-13 01:00 +0200
    Re: [PATCH v3] mmc: dw_mmc: rockchip: Set the drive phase properly Enric Balletbo Serra <eballetbo@gmail.com> - 2016-05-19 19:00 +0200

csiph-web