Re: [PATCH] arm64: Implement optimised IP checksum helpers

From	Luke Starrett <luke.starrett@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: Implement optimised IP checksum helpers
Date	2016-05-12 20:40 +0200
Message-ID	<ry3GG-2SG-15@gated-at.bofh.it> (permalink)
References	<rxZMK-7Mu-9@gated-at.bofh.it> <ry0St-l8-9@gated-at.bofh.it> <ry2hA-1IC-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Robin,

On 5/12/2016 1:08 PM, Robin Murphy wrote:
> Hi Luke,
>
> On 12/05/16 16:34, Luke Starrett wrote:
>> Hi Robin,
>>
>> I pulled this in to a userspace test app expecting that the __uint128_t
>> type might cause GCC to emit 'ldp'.  Seems like that was that your
>> intent based on your commit note.  Instead I see two 64b loads (ldr Xn),
>> and a single 32b load (ldr Wn) for the trailing 4B.  This was with
>> Linaro GCC 4.9-2015.06.
>
> GCC 5 happily emits ldp there, but indeed I couldn't figure out how to 
> convince GCC 4 to do so. From a quick ferret around in the GCC Git, it 
> looks like the relevant optimisations may have only gone in post-4.9.
>
Not a problem.  I was just curious for my own selfish reasons.

>> Otherwise, the C cycle count looks good enough compared to the asm 
>> version.
>
> Yeah, compiling as standalone functions with GCC 5 I get 19 
> instructions vs. 17 for the asm, but the loop logic gets optimised out 
> completely when ihl is a compile-time constant (e.g. inet_gro_receive())
>

I updated to Linaro GCC 5.3-2016.02, and saw what you described.  I ran 
some smoke testing against a random header generator.  LGTM.

Acked-by: Luke Starrett <luke.starrett@broadcom.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: Implement optimised IP checksum helpers Robin Murphy <robin.murphy@arm.com> - 2016-05-12 16:30 +0200
  Re: [PATCH] arm64: Implement optimised IP checksum helpers Luke Starrett <luke.starrett@broadcom.com> - 2016-05-12 17:40 +0200
    Re: [PATCH] arm64: Implement optimised IP checksum helpers Robin Murphy <robin.murphy@arm.com> - 2016-05-12 19:10 +0200
      Re: [PATCH] arm64: Implement optimised IP checksum helpers Luke Starrett <luke.starrett@broadcom.com> - 2016-05-12 20:40 +0200

csiph-web