Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1400253

[PATCH v2 2/5] IB/hfi1: Remove unused user command

From Dennis Dalessandro <dennis.dalessandro@intel.com>
Newsgroups linux.kernel
Subject [PATCH v2 2/5] IB/hfi1: Remove unused user command
Date 2016-05-12 19:20 +0200
Message-ID <ry2rg-1NT-11@gated-at.bofh.it> (permalink)
References <ry2rf-1NT-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The HFI1_CMD_SDMA_STATUS_UPD command was never implemented it has no
reason to live in the driver. Remove it.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
---
 drivers/staging/rdma/hfi1/file_ops.c |    3 ---
 include/uapi/rdma/hfi/hfi1_user.h    |    1 -
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rdma/hfi1/file_ops.c b/drivers/staging/rdma/hfi1/file_ops.c
index c1c5bf8..c5be124 100644
--- a/drivers/staging/rdma/hfi1/file_ops.c
+++ b/drivers/staging/rdma/hfi1/file_ops.c
@@ -215,7 +215,6 @@ static ssize_t hfi1_file_write(struct file *fp, const char __user *data,
 		copy = sizeof(uinfo);
 		dest = &uinfo;
 		break;
-	case HFI1_CMD_SDMA_STATUS_UPD:
 	case HFI1_CMD_CREDIT_UPD:
 		copy = 0;
 		break;
@@ -290,8 +289,6 @@ static ssize_t hfi1_file_write(struct file *fp, const char __user *data,
 		ret = get_base_info(fp, (void __user *)(unsigned long)
 				    user_val, cmd.len);
 		break;
-	case HFI1_CMD_SDMA_STATUS_UPD:
-		break;
 	case HFI1_CMD_CREDIT_UPD:
 		if (uctxt && uctxt->sc)
 			sc_return_credits(uctxt->sc);
diff --git a/include/uapi/rdma/hfi/hfi1_user.h b/include/uapi/rdma/hfi/hfi1_user.h
index a533cec..46f6caa 100644
--- a/include/uapi/rdma/hfi/hfi1_user.h
+++ b/include/uapi/rdma/hfi/hfi1_user.h
@@ -127,7 +127,6 @@
 #define HFI1_CMD_TID_UPDATE      4	/* update expected TID entries */
 #define HFI1_CMD_TID_FREE        5	/* free expected TID entries */
 #define HFI1_CMD_CREDIT_UPD      6	/* force an update of PIO credit */
-#define HFI1_CMD_SDMA_STATUS_UPD 7      /* force update of SDMA status ring */
 
 #define HFI1_CMD_RECV_CTRL       8	/* control receipt of packets */
 #define HFI1_CMD_POLL_TYPE       9	/* set the kind of polling we want */

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/5] IB/hfi1: Remove write() and use ioctl() for user  access Dennis Dalessandro <dennis.dalessandro@intel.com> - 2016-05-12 19:20 +0200
  [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands Dennis Dalessandro <dennis.dalessandro@intel.com> - 2016-05-12 19:20 +0200
    Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-05-12 19:50 +0200
      RE: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands "Hefty, Sean" <sean.hefty@intel.com> - 2016-05-12 20:20 +0200
      Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands Dennis Dalessandro <dennis.dalessandro@intel.com> - 2016-05-12 21:30 +0200
        Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-05-12 21:50 +0200
          Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands Doug Ledford <dledford@redhat.com> - 2016-05-12 21:50 +0200
            Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-05-12 23:30 +0200
              Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands Dennis Dalessandro <dennis.dalessandro@intel.com> - 2016-05-13 16:40 +0200
          Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands "ira.weiny" <ira.weiny@intel.com> - 2016-05-13 23:00 +0200
  [PATCH v2 1/5] IB/hfi1: Export drivers user sw version via sysfs Dennis Dalessandro <dennis.dalessandro@intel.com> - 2016-05-12 19:20 +0200
  [PATCH v2 2/5] IB/hfi1: Remove unused user command Dennis Dalessandro <dennis.dalessandro@intel.com> - 2016-05-12 19:20 +0200
  [PATCH v2 4/5] IB/hfi1: Remove write(), use ioctl() for user cmds Dennis Dalessandro <dennis.dalessandro@intel.com> - 2016-05-12 19:20 +0200
  [PATCH v2 5/5] IB/hfi1: Add trace message in user IOCTL handling Dennis Dalessandro <dennis.dalessandro@intel.com> - 2016-05-12 19:20 +0200
  Re: [PATCH v2 0/5] IB/hfi1: Remove write() and use ioctl() for user  access Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-05-12 19:40 +0200
    Re: [PATCH v2 0/5] IB/hfi1: Remove write() and use ioctl() for user access Dennis Dalessandro <dennis.dalessandro@intel.com> - 2016-05-12 21:10 +0200
      Re: [PATCH v2 0/5] IB/hfi1: Remove write() and use ioctl() for user  access Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-05-12 21:30 +0200
        Re: [PATCH v2 0/5] IB/hfi1: Remove write() and use ioctl() for user access Dennis Dalessandro <dennis.dalessandro@intel.com> - 2016-05-12 22:00 +0200
          Re: [PATCH v2 0/5] IB/hfi1: Remove write() and use ioctl() for user  access Doug Ledford <dledford@redhat.com> - 2016-05-12 22:40 +0200
          Re: [PATCH v2 0/5] IB/hfi1: Remove write() and use ioctl() for user  access Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-05-12 23:30 +0200

csiph-web