Re: [PATCH v2] ata: dwc: add DMADEVICES dependency

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] ata: dwc: add DMADEVICES dependency
Date	2016-05-12 18:30 +0200
Message-ID	<ry1ES-17c-9@gated-at.bofh.it> (permalink)
References	<rxCGu-Pf-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 11, 2016 at 03:42:08PM +0200, Arnd Bergmann wrote:
> The dwc_460ex SATA driver has become available on non-powerpc architectures
> and may cause randconfig build errors when CONFIG_DMADEVICES is not set
> and SATA_DWC_OLD_DMA is enabled:
> 
> warning: (SATA_DWC_OLD_DMA) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES)
> ERROR: "dw_dma_probe" [drivers/ata/sata_dwc_460ex.ko] undefined!
> ERROR: "dw_dma_remove" [drivers/ata/sata_dwc_460ex.ko] undefined!
> 
> This adds an explcit Kconfig dependency to CONFIG_SATA_DWC so we
> cannot run into broken configurations. While it would also be
> possible to build the driver with both CONFIG_DMADEVICES
> and SATA_DWC_OLD_DMA disabled, that case is not useful because
> there is no fallback to PIO mode when the DMA engine is not
> usable.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 50b433753df6 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel")

Applied to libata/for-4.7-dw.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] ata: dwc: add DMADEVICES dependency Arnd Bergmann <arnd@arndb.de> - 2016-05-11 15:50 +0200
  Re: [PATCH v2] ata: dwc: add DMADEVICES dependency Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-05-11 16:00 +0200
  Re: [PATCH v2] ata: dwc: add DMADEVICES dependency Tejun Heo <tj@kernel.org> - 2016-05-12 18:30 +0200

csiph-web