Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1400162

Re: [PATCH] net: mvneta: bm: fix dependencies again

Show all headers | View raw

Hi Arnd,
 
 On mer., mai 11 2016, Arnd Bergmann <arnd@arndb.de> wrote:

> I tried to fix this before, but my previous fix was incomplete
> and we can still get the same link error in randconfig builds
> because of the way that Kconfig treats the
>
> 	default y if MVNETA=y && MVNETA_BM_ENABLE
>
> line that does not actually trigger when MVNETA_BM_ENABLE=m,
> unlike I intended.
> Changing the line to use MVNETA_BM_ENABLE!=n however has
> the desired effect and hopefully makes all configurations
> work as expected.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 019ded3aa7c9 ("net: mvneta: bm: clarify dependencies")

It looks ok for me.

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory

> ---
>  drivers/net/ethernet/marvell/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
> index b5c6d42daa12..2664827ddecd 100644
> --- a/drivers/net/ethernet/marvell/Kconfig
> +++ b/drivers/net/ethernet/marvell/Kconfig
> @@ -68,7 +68,7 @@ config MVNETA
>  
>  config MVNETA_BM
>  	tristate
> -	default y if MVNETA=y && MVNETA_BM_ENABLE
> +	default y if MVNETA=y && MVNETA_BM_ENABLE!=n
>  	default MVNETA_BM_ENABLE
>  	select HWBM
>  	help
> -- 
> 2.7.0
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: mvneta: bm: fix dependencies again Arnd Bergmann <arnd@arndb.de> - 2016-05-11 22:20 +0200
  Re: [PATCH] net: mvneta: bm: fix dependencies again Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-05-12 17:40 +0200
  Re: [PATCH] net: mvneta: bm: fix dependencies again David Miller <davem@davemloft.net> - 2016-05-12 23:00 +0200

csiph-web