Re: [PATCH] bcache: bch_writeback_thread() is not freezable

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bcache: bch_writeback_thread() is not freezable
Date	2016-05-11 10:00 +0200
Message-ID	<rxxdM-3FS-21@gated-at.bofh.it> (permalink)
References	<rpD6G-6Tc-33@gated-at.bofh.it> <rugj8-7xc-11@gated-at.bofh.it> <rxqYF-6a9-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 10 May 2016, Eric Wheeler wrote:

> > > bch_writeback_thread() is calling try_to_freeze(), but that's just an 
> > > expensive no-op given the fact that the thread is not marked freezable.
> > > 
> > > I/O helper kthreads, exactly such as the bcache writeback thread, actually 
> > > shouldn't be freezable, because they are potentially necessary for 
> > > finalizing the image write-out.
> > > 
> > > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> > 
> > Let's send a friendly ping on these three patches after two weeks...
> 
> Maciej,
> 
> Were you able to get a backtrace?

While I'd definitely like to understand the issues in interaction between 
hibernation and bcache Maciej is supposedly seeing, this shouldn't hold 
the application of the three patches in this series, as they are just a 
cleanup that doesn't affect the behavior of the code in question.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] bcache: bch_writeback_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-02 09:20 +0200
  Re: [PATCH] bcache: bch_writeback_thread() is not freezable Eric Wheeler <bcache@lists.ewheeler.net> - 2016-05-11 03:20 +0200
    Re: [PATCH] bcache: bch_writeback_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-11 10:00 +0200

csiph-web