Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support
Date	2016-05-11 09:30 +0200
Message-ID	<rxwKK-3ri-9@gated-at.bofh.it> (permalink)
References	<rvlgJ-2Wk-5@gated-at.bofh.it> <rxwKK-3ri-11@gated-at.bofh.it> <rvlgJ-2Wk-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote:
> Recent new hardware has the ability to switch between tablet mode and
> clamshell mode. To optimize WiFi performance, we want to be able to
> use different power table between modes. This patch adds a new
> netlink message type and cfg80211_ops function to allow userspace to
> trigger a power mode switch for a given wireless interface.

I'm not a fan of this at all. Too much magic.

FWIW, we implemented something similar, currently with vendor commands,
that simply allows to set the TX power in a more controlled fashion,
i.e. allows setting TX power per band/channel range. For our device
it's only 2.4 GHz vs. 5.2 GHz, but I can imagine that you might want to
split it a bit further, so perhaps we need to advertise those ranges
somehow.

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cfg80211/nl80211: add wifi tx power mode switching support Wei-Ning Huang <wnhuang@chromium.org> - 2016-05-05 08:50 +0200
  Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching  support Dan Williams <dcbw@redhat.com> - 2016-05-05 18:10 +0200
    Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support Wei-Ning Huang <wnhuang@google.com> - 2016-05-06 10:20 +0200
      Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support Wei-Ning Huang <wnhuang@google.com> - 2016-05-11 07:10 +0200
        Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching  support Dan Williams <dcbw@redhat.com> - 2016-05-11 20:40 +0200
          Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support Wei-Ning Huang <wnhuang@google.com> - 2016-05-12 11:40 +0200
  Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching  support Johannes Berg <johannes@sipsolutions.net> - 2016-05-11 09:30 +0200

csiph-web