Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1398728

Re: [PATCH v2] pinctrl: rockchip: fix pull setting error for rk3399

Show all headers | View raw

Am Mittwoch, 11. Mai 2016, 11:39:28 schrieb Caesar Wang:
> From: David Wu <david.wu@rock-chips.com>
> 
> This patch fixes the pinctrl pull bias setting, since the pull up/down
> setting is the contrary for gpio0(just the gpio0a and gpio0b) and
> gpio2(just the gpio2c and gpio2d).
> 
> From the TRM said, the gpio0a pull polarity setting:
> gpio0a_p
> GPIO0A PE/PS programmation section, every
> GPIO bit corresponding to 2bits[PS:PE]
> 2'b00: Z(Normal operation);
> 2'b11: weak 1(pull-up);
> 2'b01: weak 0(pull-down);
> 2'b10: Z(Normal operation);

This could mention gpio2c and gpio2d as well, as the code now does.

Otherwise the patch looks good and I also compared with the TRM, so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] pinctrl: rockchip: fix pull setting error for rk3399 Caesar Wang <wxt@rock-chips.com> - 2016-05-11 05:40 +0200
  Re: [PATCH v2] pinctrl: rockchip: fix pull setting error for rk3399 Doug Anderson <dianders@chromium.org> - 2016-05-11 06:10 +0200
  Re: [PATCH v2] pinctrl: rockchip: fix pull setting error for rk3399 Heiko Stuebner <heiko@sntech.de> - 2016-05-11 09:20 +0200
  Re: [PATCH v2] pinctrl: rockchip: fix pull setting error for rk3399 Linus Walleij <linus.walleij@linaro.org> - 2016-05-11 10:50 +0200

csiph-web