Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

From	Doug Anderson <dianders@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase
Date	2016-05-11 06:00 +0200
Message-ID	<rxttv-8wf-3@gated-at.bofh.it> (permalink)
References	(3 earlier) <rwRoe-4pL-11@gated-at.bofh.it> <rwWnV-WQ-31@gated-at.bofh.it> <rxd5o-FH-17@gated-at.bofh.it> <rxieJ-5nU-3@gated-at.bofh.it> <rxsxs-7Dd-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Tue, May 10, 2016 at 7:50 PM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
>>> maybe. But I think 180(downside) is the better.
>
>
> NAK my previous comments here. Downside is better for SRD, but won't
> work for DDR mode. When running in DDR mode, we should use 90 instead.
>
> So let me elaborate a bit more here.
> For DDR mode, one single clk cycle should sending two data bits outside
> to the devices. We need a hold time for both. If 180 is used, the first
> bit occurs around the downside area, which won't be sampled by devices
> on the upside.  So on the upside, the devices will see a zero bit if you
> actually send a one-bit, which makes the devices  generate CRC finally.
>
>
> For this above, 180 for all SDR mode is ok, but 90 should be deployed
> for DDR mode. So simply checking the timing to hardcode it should be
> fine.

OK, I sent out a patch for 180 always.  I can send v2 to use 90 for
DDR modes tomorrow.  ...or feel free to post that yourself if you
want.

We want 90 for all DDR modes?  So MMC_TIMING_UHS_DDR50,
MMC_TIMING_MMC_DDR52, MMC_TIMING_MMC_HS400? (not that we support HS400
in dw_mmc on Rockchip).

-Doug

Thread

[PATCH 1/2] mmc: dw_mmc-rockchip: add default drv phase support Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-06 12:00 +0200
  [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-06 12:00 +0200
    Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase Doug Anderson <dianders@chromium.org> - 2016-05-06 19:30 +0200
      Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add  rockchip,default-drv-phase Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-09 13:20 +0200
        Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase Doug Anderson <dianders@chromium.org> - 2016-05-09 18:40 +0200
          Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add  rockchip,default-drv-phase Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-10 12:30 +0200
            Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase Doug Anderson <dianders@chromium.org> - 2016-05-10 18:00 +0200
              Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add  rockchip,default-drv-phase Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-11 05:00 +0200
                Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase Doug Anderson <dianders@chromium.org> - 2016-05-11 06:00 +0200
                Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add  rockchip,default-drv-phase Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-11 10:30 +0200
                Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase Doug Anderson <dianders@chromium.org> - 2016-05-11 23:50 +0200
                Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add  rockchip,default-drv-phase Shawn Lin <shawn.lin@kernel-upstream.org> - 2016-05-12 05:10 +0200
  Re: [PATCH 1/2] mmc: dw_mmc-rockchip: add default drv phase support Doug Anderson <dianders@chromium.org> - 2016-05-06 19:30 +0200

csiph-web