Re: [PATCH] [media] v4l2-async: Pass the v4l2_async_subdev to the unbind callback

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [media] v4l2-async: Pass the v4l2_async_subdev to the unbind callback
Date	2016-05-10 23:50 +0200
Message-ID	<rxnHs-2F8-19@gated-at.bofh.it> (permalink)
References	<rxfJU-32e-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Alban,

On 05/10/2016 09:19 AM, Alban Bedel wrote:
> v4l2_async_cleanup() is always called before before calling the
> unbind() callback. However v4l2_async_cleanup() clear the asd member,
> so when calling the unbind() callback the v4l2_async_subdev is always
> NULL. To fix this save the asd before calling v4l2_async_cleanup().
> 
> Signed-off-by: Alban Bedel <alban.bedel@avionic-design.de>
> ---

Patch looks good to me. So after fixing the issues pointed out by Sakari:

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] v4l2-async: Pass the v4l2_async_subdev to the unbind callback Alban Bedel <alban.bedel@avionic-design.de> - 2016-05-10 15:20 +0200
  Re: [PATCH] [media] v4l2-async: Pass the v4l2_async_subdev to the  unbind callback Sakari Ailus <sakari.ailus@iki.fi> - 2016-05-10 20:50 +0200
  Re: [PATCH] [media] v4l2-async: Pass the v4l2_async_subdev to the  unbind callback Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-10 23:50 +0200

csiph-web