Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1398469

Re: [PATCH 1/2] MIPS: Disable preemption during prctl(PR_SET_FP_MODE, ...)

Path csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Aurelien Jarno <aurelien@aurel32.net>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] MIPS: Disable preemption during prctl(PR_SET_FP_MODE, ...)
Date Tue, 10 May 2016 22:20:03 +0200
Message-ID <rxmin-1nf-43@gated-at.bofh.it> (permalink)
References <rqlhn-8vU-9@gated-at.bofh.it>
X-Original-To Paul Burton <paul.burton@imgtec.com>
X-Greylist delayed 2268 seconds by postgrey-1.27 at vger.kernel.org; Tue, 10 May 2016 16:10:40 EDT
Mail-Followup-To Paul Burton <paul.burton@imgtec.com>, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, "stable # v4 . 0+" <stable@vger.kernel.org>, Adam Buchbinder <adam.buchbinder@gmail.com>, linux-kernel@vger.kernel.org, James Hogan <james.hogan@imgtec.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.6.0 (2016-04-01)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 30
Organization linux.* mail to news gateway
X-Original-Cc linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, "stable # v4 . 0+" <stable@vger.kernel.org>, Adam Buchbinder <adam.buchbinder@gmail.com>, linux-kernel@vger.kernel.org, James Hogan <james.hogan@imgtec.com>
X-Original-Date Tue, 10 May 2016 21:32:46 +0200
X-Original-Message-ID <20160510193246.GB7635@aurel32.net>
X-Original-References <1461239038-19991-1-git-send-email-paul.burton@imgtec.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1398469

Show key headers only | View raw


On 2016-04-21 12:43, Paul Burton wrote:
> Whilst a PR_SET_FP_MODE prctl is performed there are decisions made
> based upon whether the task is executing on the current CPU. This may
> change if we're preempted, so disable preemption to avoid such changes
> for the lifetime of the mode switch.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Fixes: 9791554b45a2 ("MIPS,prctl: add PR_[GS]ET_FP_MODE prctl options for MIPS")
> Cc: stable <stable@vger.kernel.org> # v4.0+
> ---
> 
>  arch/mips/kernel/process.c | 4 ++++
>  1 file changed, 4 insertions(+)

Both patches fixes building pillow, which otherwise hangs running
"python setup.py build" [1]. The setup code uses the multiprocessing
package, and it hangs in a call to PR_SET_FP_MODE.

You can therefore add for both patches:

Tested-by: Aurelien Jarno <aurelien@aurel32.net>

Thanks,
Aurelien

[1] https://buildd.debian.org/status/fetch.php?pkg=pillow&arch=mips&ver=3.2.0-1&stamp=1460852908

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 1/2] MIPS: Disable preemption during  prctl(PR_SET_FP_MODE, ...) Aurelien Jarno <aurelien@aurel32.net> - 2016-05-10 22:20 +0200

csiph-web