Re: [PATCH] fs: befs: use flags field to validate fs state

From	Andrew Morton <akpm@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fs: befs: use flags field to validate fs state
Date	2016-05-10 21:20 +0200
Message-ID	<rxlmi-zy-17@gated-at.bofh.it> (permalink)
References	<rxlcC-uF-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 10 May 2016 19:59:42 +0100 Salah Triki <salah.triki@acm.org> wrote:

> flags field records the state of the superblock, so it is
> more appropriate to use this field for validating the fs state than
> using the fields log_start and log_end.
> 
> Signed-off-by: Salah Triki <salah.triki@acm.org>
> ---
>  fs/befs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/befs/super.c b/fs/befs/super.c
> index aeafc4d..079fc00 100644
> --- a/fs/befs/super.c
> +++ b/fs/befs/super.c
> @@ -101,7 +101,7 @@ befs_check_sb(struct super_block *sb)
>  		return BEFS_ERR;
>  	}
>  
> -	if (befs_sb->log_start != befs_sb->log_end) {
> +	if (befs_sb->flags == BFS_DIRTY) {
>  		befs_error(sb, "Filesystem not clean! There are blocks in the "
>  			   "journal. You must boot into BeOS and mount this volume "
>  			   "to make it clean.");

Has this been tested?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fs: befs: use flags field to validate fs state Salah Triki <salah.triki@acm.org> - 2016-05-10 21:10 +0200
  Re: [PATCH] fs: befs: use flags field to validate fs state Andrew Morton <akpm@linux-foundation.org> - 2016-05-10 21:20 +0200

csiph-web