Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1398453
| From | Anand Moon <linux.amoon@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes |
| Date | 2016-05-10 21:50 +0200 |
| Message-ID | <rxlPk-Q2-17@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <rxb3A-70Q-19@gated-at.bofh.it> <rxc9j-84z-3@gated-at.bofh.it> <rxfgT-2rD-17@gated-at.bofh.it> <rxgwj-3Ly-41@gated-at.bofh.it> <rxgwj-3Ly-39@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Krzysztof,
On 10 May 2016 at 19:33, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> On 05/10/2016 04:00 PM, Anand Moon wrote:
>> Hi Krzysztof,
>>
>> On 10 May 2016 at 18:13, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>> On 05/10/2016 11:29 AM, Anand Moon wrote:
>>>>>
>>>>> I am sorry but I do not understand.
>>>>> 1. Are you saying that my patch causes the issue?
>>>>> 2. Are you saying that I should not send some patches because of
>>>>> conflicting work? (that would be peculiar...)
>>>>> 3. Are you saying that I should not apply this patch to me tree because
>>>>> of conflicting work?
>>>>> 4. Other?
>>>>>
>>>>> Best regards.
>>>>> Krzysztof
>>>>>
>>>>>
>>>>
>>>> Sorry for the confusion it's not about you patch.
>>>> The feature is not working correctly as per my testing with the
>>>> original source code.
>>>> It need to be more tuned or some other approach to the issue need to found.
>>>
>>> Known issue. You don't have cpufreq cooling enabled. I sent patches for
>>> that and they are in the mainline. However cpufreq cooling requires
>>> cpufreq which cannot work with BL_SWITCHER and on Exynos542x on
>>> exynos_defconfig BL_SWITCHER is enabled.
>>>
>>> Just disable the BL_Krzysztof.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> I have already disabled BL_SWITCHER in my exynos_defconfig. to support
>> CONFIG_CPUFREQ_DT.
>>
>> But how about adjust the the cputemp so that all the core will have
>> same tip points.
>
>
> I don't understand you. All of the cores have same trip points.
>
> Best regards,
> Krzysztof
>
>>
>> xcpu0-t 0:[ 44][>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> A50
>> A60 P70 P85 C120
>> ]
>> xcpu1-t 1:[ 46][>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>> A85 A103 A110 C120
>> ]
>> xcpu2-t 2:[ 51][>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>> A85 A103 A110 C120 ]
>> xcpu3-t 3:[ 47][>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>> A85 A103 A110 C120 ]
>> xgpu-th 4:[ 48][>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>> A85 A103 A110 C120 ]
>
>
Sorry I am not able to explain my self clearly.
But I have once gain tested these changes.
Only could you append with following changes.
--------------------------------------------------------
+ cpu_crit0: cpu-crit-0 {
+ temperature = <120000>; /*
millicelsius */
+ hysteresis = <5000>; /* millicelsius */
+ type = "critical";
+ };
--------------------------------------------------------
hysteresis time help to adjust the present and past temperature inputs
before critical shutdown.
Tested-by: Anand Moon <linux.amoon@gmail.com>
Best Regards
-Anand Moon
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-09 08:30 +0200
Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-09 18:50 +0200
Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Anand Moon <linux.amoon@gmail.com> - 2016-05-10 08:50 +0200
Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-10 10:20 +0200
Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Anand Moon <linux.amoon@gmail.com> - 2016-05-10 11:30 +0200
Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-10 14:50 +0200
Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-10 16:10 +0200
Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Anand Moon <linux.amoon@gmail.com> - 2016-05-10 21:50 +0200
Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-11 07:50 +0200
Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Anand Moon <linux.amoon@gmail.com> - 2016-05-11 09:30 +0200
Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Anand Moon <linux.amoon@gmail.com> - 2016-05-10 16:10 +0200
csiph-web