Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1398329

Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event.

From Eric Anholt <eric@anholt.net>
Newsgroups linux.kernel
Subject Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event.
Date 2016-05-10 19:10 +0200
Message-ID <rxjku-6P9-9@gated-at.bofh.it> (permalink)
References <ruMCn-3Wx-21@gated-at.bofh.it> <ruOb7-5Gk-7@gated-at.bofh.it> <rxhVo-59L-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Robert Foss <robert.foss@collabora.com> writes:

> On 2016-05-03 03:22 PM, Eric Anholt wrote:
>> robert.foss@collabora.com writes:
>>
>>> From: Robert Foss <robert.foss@collabora.com>
>>>
>>> As per the documentation in drm_crtc.h, atomic_commit should return
>>> -EBUSY if an asycnhronous update is requested and there is an earlier
>>> update pending.
>>>
>>> Note: docs cited here are drm_crtc.h, and the whole quote is:
>>>
>>>      *  - -EBUSY, if an asynchronous updated is requested and there is
>>>      *    an earlier updated pending. Drivers are allowed to support a queue
>>>      *    of outstanding updates, but currently no driver supports that.
>>>      *    Note that drivers must wait for preceding updates to complete if a
>>>      *    synchronous update is requested, they are not allowed to fail the
>>>      *    commit in that case.
>>>
>>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>>
>> This looks good to me.  Let's give it a few days on the list for any
>> other KMS folks to catch anything.
>>
>
> I haven't seen any further feedback regarding this patch.
> Does anyone have objections to it being merged?

I merged it to drm-vc4-next last night, actually :)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event. robert.foss@collabora.com - 2016-05-03 19:50 +0200
  Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event. Eric Anholt <eric@anholt.net> - 2016-05-03 21:30 +0200
    Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending  flip event. Robert Foss <robert.foss@collabora.com> - 2016-05-10 17:40 +0200
      Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event. Eric Anholt <eric@anholt.net> - 2016-05-10 19:10 +0200
        Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending  flip event. Robert Foss <robert.foss@collabora.com> - 2016-05-10 19:20 +0200

csiph-web