Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1398151

Re: [PATCH 2/3] of: Support hashtable lookups for phandles

Show all headers | View raw

On Tue, May 10, 2016 at 8:45 AM, Pantelis Antoniou
<pantelis.antoniou@konsulko.com> wrote:
> Hi Rob,
>
>> On May 10, 2016, at 00:11 , Rob Herring <robherring2@gmail.com> wrote:
>>
>> On Mon, May 9, 2016 at 3:38 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>> Hi Pantelis,
>>>
>>> On Mon, May 9, 2016 at 8:11 PM, Pantelis Antoniou
>>> <pantelis.antoniou@konsulko.com> wrote:
>>>> --- a/drivers/of/base.c
>>>> +++ b/drivers/of/base.c
>>>
>>>> @@ -1073,9 +1097,14 @@ struct device_node *of_find_node_by_phandle(phandle handle)
>>>>                return NULL;
>>>>
>>>>        raw_spin_lock_irqsave(&devtree_lock, flags);
>>>> -       for_each_of_allnodes(np)
>>>> -               if (np->phandle == handle)
>>>> -                       break;
>>>> +       /* when we're ready use the hash table */
>>>> +       if (of_phandle_ht_available() && !in_interrupt())
>>>
>>> I guess the !in_interrupt() test is because of the locking inside
>>> rhashtable_lookup_fast()?
>>
>> Not a use we should support. Just warn for anyone parsing DT in
>> interrupt context.
>>
>
> That’s not about users calling in interrupt context. It’s when we’re
> very early in the boot sequence we’re under interrupt context and
> calls to the hash methods cannot be made.

I don't understand. When exactly are we in interrupt context?

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] of: generic infrastructure fixes Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-05-09 20:20 +0200
  [PATCH 2/3] of: Support hashtable lookups for phandles Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-05-09 20:20 +0200
    Re: [PATCH 2/3] of: Support hashtable lookups for phandles Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-09 22:40 +0200
      Re: [PATCH 2/3] of: Support hashtable lookups for phandles Rob Herring <robherring2@gmail.com> - 2016-05-09 23:20 +0200
        Re: [PATCH 2/3] of: Support hashtable lookups for phandles Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-05-10 15:50 +0200
          Re: [PATCH 2/3] of: Support hashtable lookups for phandles Rob Herring <robherring2@gmail.com> - 2016-05-10 16:30 +0200
    Re: [PATCH 2/3] of: Support hashtable lookups for phandles Rob Herring <robherring2@gmail.com> - 2016-05-09 23:30 +0200
      Re: [PATCH 2/3] of: Support hashtable lookups for phandles Pantelis Antoniou <panto@antoniou-consulting.com> - 2016-05-10 16:10 +0200
  [PATCH 3/3] of: overlay: Pick up label symbols from overlays. Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-05-09 20:20 +0200
    Re: [PATCH 3/3] of: overlay: Pick up label symbols from overlays. Marek Vasut <marex@denx.de> - 2016-05-09 22:40 +0200
    Re: [PATCH 3/3] of: overlay: Pick up label symbols from overlays. Rob Herring <robherring2@gmail.com> - 2016-05-09 23:50 +0200
      Re: [PATCH 3/3] of: overlay: Pick up label symbols from overlays. Pantelis Antoniou <panto@antoniou-consulting.com> - 2016-05-10 16:10 +0200
        Re: [PATCH 3/3] of: overlay: Pick up label symbols from overlays. Rob Herring <robherring2@gmail.com> - 2016-05-10 16:30 +0200
  [PATCH 1/3] of: rename *_node_sysfs to _node_post Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-05-09 20:20 +0200
    Re: [PATCH 1/3] of: rename *_node_sysfs to _node_post Rob Herring <robherring2@gmail.com> - 2016-05-09 23:50 +0200
      Re: [PATCH 1/3] of: rename *_node_sysfs to _node_post Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-05-10 16:00 +0200

csiph-web