Re: [PATCH v7 5/5] usb: dwc3: core: cleanup IRQ resources

From	Roger Quadros <rogerq@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 5/5] usb: dwc3: core: cleanup IRQ resources
Date	2016-05-10 13:50 +0200
Message-ID	<rxekO-1Bh-15@gated-at.bofh.it> (permalink)
References	<rxcCp-8kL-61@gated-at.bofh.it> <rxcCr-8kL-99@gated-at.bofh.it> <rxcM1-qT-3@gated-at.bofh.it> <rxcVI-yd-9@gated-at.bofh.it> <rxcVJ-yd-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/05/16 13:14, Felipe Balbi wrote:
> 
> Hi,
> 
> Roger Quadros <rogerq@ti.com> writes:
>>>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>>>> index 186a886..2e20892 100644
>>>> --- a/drivers/usb/dwc3/core.h
>>>> +++ b/drivers/usb/dwc3/core.h
>>>> @@ -716,6 +716,8 @@ struct dwc3_scratchpad_array {
>>>>   * @maximum_speed: maximum speed requested (mainly for testing purposes)
>>>>   * @revision: revision register contents
>>>>   * @dr_mode: requested mode of operation
>>>> + * @gadget_irq: IRQ number for Peripheral IRQs
>>>> + * @otg_irq: IRQ number for OTG IRQs
>>>>   * @usb2_phy: pointer to USB2 PHY
>>>>   * @usb3_phy: pointer to USB3 PHY
>>>>   * @usb2_generic_phy: pointer to USB2 PHY
>>>> @@ -817,6 +819,9 @@ struct dwc3 {
>>>>  
>>>>  	enum usb_dr_mode	dr_mode;
>>>>  
>>>> +	int			gadget_irq;
>>>> +	int			otg_irq;
>>>
>>> while at that, let's add host_irq too and do proper changes to dwc3/host.c
>>
>> Sure. So we add host_irq here, and manually create an irq resource
>> in dwc3_host_init?
> 
> right :-) Then the code looks similar for otg, peripheral and host parts ;-)
> 
Just saw that host_irq is not used anywhere other than creating the XHCI platform
device. So I don't see why we need host_irq in struct dwc3.
It is obtained in dwc3_host_init() and consumed there itself.

cheers,
-roger

Thread

[PATCH v7 0/5] dwc3: omap: fixes and dual-role preparation Roger Quadros <rogerq@ti.com> - 2016-05-10 12:00 +0200
  [PATCH v7 5/5] usb: dwc3: core: cleanup IRQ resources Roger Quadros <rogerq@ti.com> - 2016-05-10 12:00 +0200
    Re: [PATCH v7 5/5] usb: dwc3: core: cleanup IRQ resources Felipe Balbi <balbi@kernel.org> - 2016-05-10 12:10 +0200
      Re: [PATCH v7 5/5] usb: dwc3: core: cleanup IRQ resources Roger Quadros <rogerq@ti.com> - 2016-05-10 12:20 +0200
        Re: [PATCH v7 5/5] usb: dwc3: core: cleanup IRQ resources Felipe Balbi <balbi@kernel.org> - 2016-05-10 12:20 +0200
          Re: [PATCH v7 5/5] usb: dwc3: core: cleanup IRQ resources Roger Quadros <rogerq@ti.com> - 2016-05-10 13:50 +0200
            Re: [PATCH v7 5/5] usb: dwc3: core: cleanup IRQ resources Felipe Balbi <balbi@kernel.org> - 2016-05-10 14:00 +0200

csiph-web