RE: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock

From	Peng Fan <peng.fan@nxp.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock
Date	2016-05-10 14:20 +0200
Message-ID	<rxeNP-2bK-1@gated-at.bofh.it> (permalink)
References	<rpWsF-5yx-9@gated-at.bofh.it> <rpWsF-5yx-7@gated-at.bofh.it> <rwStY-5zM-25@gated-at.bofh.it> <rwSNk-5L9-23@gated-at.bofh.it> <rxdf3-KB-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Srinivas Kandagatla
> Sent: Tuesday, May 10, 2016 6:32 PM
> To: Peng Fan <van.freenix@gmail.com>
> Cc: shawnguo@kernel.org; maxime.ripard@free-electrons.com; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock
> 
> 
> 
> On 09/05/16 13:41, Peng Fan wrote:
> > Hi Srinivas,
> >
> > On Mon, May 09, 2016 at 01:28:14PM +0100, Srinivas Kandagatla wrote:
> >> Thanks for the Ping, I totally missed this thread.
> >>
> >> On 20/04/16 18:26, Peng Fan wrote:
> >>> Before access ocotp nvmem area, the clock should be enabled.
> >>> Or, `hexdump nvmem` will hang the system. So, use such flow:
> >>> "
> >>>    1. clock_enable_prepare
> >>>    2. read nvmem ocotp area
> >>>    3. clock_disable_unprepare
> >>> "
> >>>
> >>> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> >>> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> >>> Cc: Shawn Guo <shawnguo@kernel.org>
> >>> ---
> >>>
> >>> V2:
> >>>   Follow Fabio's comments, check return value of clk_prepare_enable
> >>>
> >>>   drivers/nvmem/imx-ocotp.c | 16 +++++++++++++++-
> >>>   1 file changed, 15 insertions(+), 1 deletion(-)
> >>
> >> Changes to the driver looks good to me, Only one comment, As the
> >> clock property is now made mandatory, you should update the
> >> dt-bindings with this info too.
> >
> > In Documentation/devicetree/bindings/nvmem/imx-ocotp.txt,
> > the clock property is already marked Required properties:
> 
> Ok, I can take this patch, dt patch should go via the dt maintainers.

Thanks, Srinivas.

Shawn,

Will you review and pick up the other two patches, since changes to i.MX dts files?

https://lkml.org/lkml/2016/4/20/150          arm: dts: imx6qdl: add clocks property for ocotp node  
https://lkml.org/lkml/2016/4/20/153          arm: dts: imx6sl: add clocks property for ocotp node

Thanks,
Peng.
> 
> thanks,
> --srini

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-05-09 14:30 +0200
  Re: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock Peng Fan <van.freenix@gmail.com> - 2016-05-09 14:50 +0200
    Re: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-05-10 12:40 +0200
      RE: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock Peng Fan <peng.fan@nxp.com> - 2016-05-10 14:20 +0200

csiph-web