Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399831

Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger

Show all headers | View raw

On Wed, 2016-05-04 at 09:29 +0200, Pavel Machek wrote:
> 
> If userspace wants to control the manually, it can do just that --
> control it manually. There should not be a need to "override the
> default policy".

I'm still not buying this.

In the original situation, without these patches, userspace has to have
a list of all LEDs that are supposed to indicate airplane mode.

With this patch only (without patch 2/3), userspace can look up the
default trigger, but then has to change it, causing the necessary
information to be lost immediately when you actually use it - that also
seems like a bad idea.

With the patches, the userspace that cares can also concentrate on
something it already *does* - i.e. dealing with the rfkill API - and
let the rest of the situation be sorted out in itself.


Now, if the LED subsystem had a really good way of specifying LED
intent, and it was widely used, and rfkill didn't already concern
itself with the rfkill status of all devices ... yeah maybe this
wouldn't be needed. As it stands, I still think this is the best way
forward.

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH 0/3] RFKill airplane-mode indicator "João Paulo Rechi Vita" <jprvita@gmail.com> - 2016-05-02 16:50 +0200
  [RESEND PATCH 3/3] rfkill: Notify userspace of airplane-mode state changes "João Paulo Rechi Vita" <jprvita@gmail.com> - 2016-05-02 16:50 +0200
  [RESEND PATCH 2/3] rfkill: Userspace control for airplane mode "João Paulo Rechi Vita" <jprvita@gmail.com> - 2016-05-02 16:50 +0200
  [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger "João Paulo Rechi Vita" <jprvita@gmail.com> - 2016-05-02 16:50 +0200
    Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED  trigger Pavel Machek <pavel@ucw.cz> - 2016-05-04 09:30 +0200
      Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED  trigger Johannes Berg <johannes@sipsolutions.net> - 2016-05-12 11:40 +0200
        Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED  trigger Pavel Machek <pavel@ucw.cz> - 2016-05-19 09:20 +0200

csiph-web