Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1399759
| From | He Kuang <hekuang@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given |
| Date | 2016-05-12 10:50 +0200 |
| Message-ID | <rxUtI-1Wg-9@gated-at.bofh.it> (permalink) |
| References | <rxUtI-1Wg-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Symfs dir and buildid dir are two places that perf looks into for symbols, currently, if symfs dir is given, buildid-cache is skipped. In the cross-platform perf record/script scenario, we need vdsos in buildid-cache dir and other libs in symfs dir at the same time. And consider that the binaries indexed by buildid do not cause ambiguity, this patch simply removes that logical. Signed-off-by: He Kuang <hekuang@huawei.com> --- tools/perf/util/dso.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index b39b80c..a07166c5 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c @@ -64,8 +64,7 @@ int dso__read_binary_type_filename(const struct dso *dso, break; case DSO_BINARY_TYPE__BUILD_ID_CACHE: /* skip the locally configured cache if a symfs is given */ - if (symbol_conf.symfs[0] || - (dso__build_id_filename(dso, filename, size) == NULL)) + if (dso__build_id_filename(dso, filename, size) == NULL) ret = -1; break; -- 1.8.5.2
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given He Kuang <hekuang@huawei.com> - 2016-05-12 10:50 +0200
Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-12 15:10 +0200
Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given David Ahern <dsahern@gmail.com> - 2016-05-12 22:30 +0200
Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-12 22:40 +0200
Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given Hekuang <hekuang@huawei.com> - 2016-05-13 09:30 +0200
Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given David Ahern <dsahern@gmail.com> - 2016-05-13 16:30 +0200
Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-13 20:10 +0200
[PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs He Kuang <hekuang@huawei.com> - 2016-05-14 10:30 +0200
Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs David Ahern <dsahern@gmail.com> - 2016-05-14 16:50 +0200
Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs Hekuang <hekuang@huawei.com> - 2016-05-16 04:10 +0200
Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs David Ahern <dsahern@gmail.com> - 2016-05-16 05:00 +0200
Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs Hekuang <hekuang@huawei.com> - 2016-05-16 08:50 +0200
Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs Hekuang <hekuang@huawei.com> - 2016-05-18 04:00 +0200
Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs David Ahern <dsahern@gmail.com> - 2016-05-18 04:00 +0200
Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs Hekuang <hekuang@huawei.com> - 2016-05-18 05:00 +0200
Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs David Ahern <dsahern@gmail.com> - 2016-05-18 05:10 +0200
csiph-web