Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1399732

[PATCH v9 3/8] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()

From David Wu <david.wu@rock-chips.com>
Newsgroups linux.kernel
Subject [PATCH v9 3/8] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()
Date 2016-05-12 10:00 +0200
Message-ID <rxTHl-1bV-13@gated-at.bofh.it> (permalink)
References <rxTHk-1bV-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


rk3x_i2c_setup() gets called directly before rk3x_i2c_start(),
and the last thing in setup was to clean the IPD, so no reason
to do it at the beginning of start.

Signed-off-by: David Wu <david.wu@rock-chips.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---
Change in v9:
- modify commit message

Change in v8:
- none

 drivers/i2c/busses/i2c-rk3x.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index 1e2677a..9eeb4e5 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -174,7 +174,6 @@ static void rk3x_i2c_start(struct rk3x_i2c *i2c)
 {
 	u32 val;
 
-	rk3x_i2c_clean_ipd(i2c);
 	i2c_writel(i2c, REG_INT_START, REG_IEN);
 
 	/* enable adapter with correct mode, send START condition */
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v9 0/8] add i2c driver supported for rk3399 David Wu <david.wu@rock-chips.com> - 2016-05-12 10:00 +0200
  [PATCH v9 4/8] i2c: rk3x: Change SoC data to not use array David Wu <david.wu@rock-chips.com> - 2016-05-12 10:00 +0200
  [PATCH v9 2/8] i2c: rk3x: use struct "rk3x_i2c_calced_timings" David Wu <david.wu@rock-chips.com> - 2016-05-12 10:00 +0200
  [PATCH v9 3/8] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd() David Wu <david.wu@rock-chips.com> - 2016-05-12 10:00 +0200
  [PATCH v9 1/8] i2c: rk3x: add documentation to fields in "struct rk3x_i2c" David Wu <david.wu@rock-chips.com> - 2016-05-12 10:00 +0200
  [PATCH v9 8/8] i2c: rk3x: support fast-mode plus for rk3399 David Wu <david.wu@rock-chips.com> - 2016-05-12 10:10 +0200
  Re: [PATCH v9 0/8] add i2c driver supported for rk3399 Heiko Stuebner <heiko@sntech.de> - 2016-05-14 13:40 +0200

csiph-web