Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399702

Re: [PATCH] NVMe: Only release requested regions

Show all headers | View raw

>  static void nvme_dev_unmap(struct nvme_dev *dev)
>  {
> +	struct pci_dev *pdev = to_pci_dev(dev->dev);
> +	int bars;
> +
>  	if (dev->bar)
>  		iounmap(dev->bar);
> -	pci_release_regions(to_pci_dev(dev->dev));
> +
> +	bars = pci_select_bars(pdev, IORESOURCE_MEM);
> +	pci_release_selected_regions(pdev, bars);

This looks fine, but I really hate this API.

Can someone add these two nice helpers to pci.h:

static inline int
pci_request_mem_regions(struct pci_dev *pdev, const char *name)
{
	return pci_request_selected_regions(pdev,
			pci_select_bars(pdev, IORESOURCE_MEM), name);
}

static inline void
pci_release_mem_regions(struct pci_dev *pdev)
{
	return pci_release_selected_regions(pdev,
			pci_select_bars(pdev, IORESOURCE_MEM));
}

But for now this should do it:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] NVMe: Only release requested regions Johannes Thumshirn <jthumshirn@suse.de> - 2016-05-10 15:20 +0200
  Re: [PATCH] NVMe: Only release requested regions Christoph Hellwig <hch@infradead.org> - 2016-05-12 09:10 +0200
    Re: [PATCH] NVMe: Only release requested regions Johannes Thumshirn <jthumshirn@suse.de> - 2016-05-12 09:40 +0200
  Re: [PATCH] NVMe: Only release requested regions Johannes Thumshirn <jthumshirn@suse.de> - 2016-05-24 11:20 +0200
    Re: [PATCH] NVMe: Only release requested regions Christoph Hellwig <hch@infradead.org> - 2016-05-24 11:20 +0200
      Re: [PATCH] NVMe: Only release requested regions Keith Busch <keith.busch@intel.com> - 2016-05-24 16:30 +0200

csiph-web