Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399654

Re: [PATCH v2 0/3] input: rmi4: Regulator supply support

Show all headers | View raw

On Wed 11 May 16:30 PDT 2016, Andrew Duggan wrote:

> Hi Bjorn,
> 
> On 05/10/2016 08:49 AM, Bjorn Andersson wrote:
[..]
> >So either we duplicate the regulator support in spi/i2c or we make them
> >optional in the core driver. Sounds like you prefer the prior, i.e. v1
> >of my patch.
> 
> Yes, after all this I think it makes sense to put regulator support in the
> spi/i2c transports like in your v1 patch. I essentially duplicated the irq
> handling code in both transports so I would be ok with duplicating regulator
> support too. It doesn't seem like that much code. But, if this is too much
> duplication we could create some sort of common file and put the common irq
> and regulator support functions which could be called in the transports.
> Similar to how rmi_2d_sensor.c defines some common functions shared between
> rmi_f11 and rmi_f12.
> 

Sounds reasonable, I'm okay with this. Did you have any comments on the
implementation I had in v1?

@Dmitry, do you want me to resend v1?

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] Input: synaptics-rmi4: Support regulator supplies Andrew Duggan <aduggan@synaptics.com> - 2016-05-05 23:00 +0200
  Re: [PATCH] Input: synaptics-rmi4: Support regulator supplies Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-06 03:00 +0200
    [PATCH v2 0/3] input: rmi4: Regulator supply support Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-07 06:50 +0200
      [PATCH v2 1/3] input: rmi4: Move IRQ handling to rmi_driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-07 06:50 +0200
      [PATCH v2 2/3] input: rmi4: Acquire and enable VDD and VIO supplies Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-07 06:50 +0200
        Re: [PATCH v2 2/3] input: rmi4: Acquire and enable VDD and VIO  supplies Rob Herring <robh@kernel.org> - 2016-05-09 22:00 +0200
      Re: [PATCH v2 0/3] input: rmi4: Regulator supply support Andrew Duggan <aduggan@synaptics.com> - 2016-05-10 02:40 +0200
        Re: [PATCH v2 0/3] input: rmi4: Regulator supply support Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-10 17:50 +0200
          Re: [PATCH v2 0/3] input: rmi4: Regulator supply support Andrew Duggan <aduggan@synaptics.com> - 2016-05-12 01:40 +0200
            Re: [PATCH v2 0/3] input: rmi4: Regulator supply support Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-12 05:10 +0200
              Re: [PATCH v2 0/3] input: rmi4: Regulator supply support Andrew Duggan <aduggan@synaptics.com> - 2016-05-13 03:00 +0200
                Re: [PATCH v2 0/3] input: rmi4: Regulator supply support Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-14 00:30 +0200
                Re: [PATCH v2 0/3] input: rmi4: Regulator supply support Andrew Duggan <aduggan@synaptics.com> - 2016-05-17 02:00 +0200

csiph-web