Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

From	Hongzhou Yang <hongzhou.yang@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode
Date	2016-05-12 05:00 +0200
Message-ID	<rxP0Z-4Bd-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <rxbdh-76W-29@gated-at.bofh.it> <rxAY2-7z7-13@gated-at.bofh.it> <rxHd8-5ub-19@gated-at.bofh.it> <rxNVg-3vp-13@gated-at.bofh.it> <rxOeC-3YK-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote:
> On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote:
> > Hi,
> > 
> > On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote:
> > > On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote:
> > > > On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun
> > > > <chunfeng.yun@mediatek.com> wrote:
> > > > 
> > > > > the default mode of GPIO16 pin is gpio, when set EINT16 to
> > > > > IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be
> > > > > fixed when set its default mode as usb iddig.
> > > > >
> > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > > 
> > > 
> > > Chunfeng, GPIO16 can be used as EINT16 mode, but the pinmux should be 0.
> > > If you want to set its default mode to iddig, you should set it in dts.
> > > 
> > I set it in DTS, but it didn't work, because when usb driver requested
> > IRQ, pinmux was switched back to default mode set by
> > MTK_EINT_FUNCTION().
> > 
> 
> After confirmed, there are something wrong with data sheet and pinmux
> table, and GPIO16 can only receive interrupt by mode 1. So
> 
> Acked-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
> 

Linus,

We find there are some other pins still have the same problem, so please
hold on it. Sorry for so much noise.

Thanks,
Hongzhou

Thread

Add MediaTek USB3 DRD Driver Chunfeng Yun <chunfeng.yun@mediatek.com> - 2016-05-10 10:30 +0200
  [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode Chunfeng Yun <chunfeng.yun@mediatek.com> - 2016-05-10 10:30 +0200
    Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode Linus Walleij <linus.walleij@linaro.org> - 2016-05-11 14:00 +0200
      Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode Hongzhou Yang <hongzhou.yang@mediatek.com> - 2016-05-11 20:40 +0200
        Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode chunfeng yun <chunfeng.yun@mediatek.com> - 2016-05-12 03:50 +0200
          Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode Hongzhou Yang <hongzhou.yang@mediatek.com> - 2016-05-12 04:10 +0200
            Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode Hongzhou Yang <hongzhou.yang@mediatek.com> - 2016-05-12 05:00 +0200
              Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode Linus Walleij <linus.walleij@linaro.org> - 2016-05-24 13:00 +0200
  [PATCH 2/6] usb: xhci-mtk: make IPPC register optional Chunfeng Yun <chunfeng.yun@mediatek.com> - 2016-05-10 10:30 +0200

csiph-web