Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399574

[PATCH v2 20/32] perf/x86/intel/cqm: handle inherit event and inherit_stat flag

Show all headers | View raw

Since inherited events are part of the same cqm cache group, they share the
RMID and therefore they cannot provide the granularity required by
inherit_stats. Changing this would in the current approach would require to
create a subtree of monrs for each parent event, with its inherited events
as descendats, a potential improvement for future patches.

Reviewed-by: Stephane Eranian <eranian@google.com>
Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
---
 arch/x86/events/intel/cqm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/events/intel/cqm.c b/arch/x86/events/intel/cqm.c
index b241268..5314a33 100644
--- a/arch/x86/events/intel/cqm.c
+++ b/arch/x86/events/intel/cqm.c
@@ -2470,6 +2470,7 @@ static int intel_cqm_event_init(struct perf_event *event)
 	    event->attr.exclude_idle   ||
 	    event->attr.exclude_host   ||
 	    event->attr.exclude_guest  ||
+	    event->attr.inherit_stat   || /* cqm groups share rmid */
 	    event->attr.sample_period) /* no sampling */
 		return -EINVAL;
 
-- 
2.8.0.rc3.226.g39d4020

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 20/32] perf/x86/intel/cqm: handle inherit event and inherit_stat flag David Carrillo-Cisneros <davidcc@google.com> - 2016-05-12 01:10 +0200

csiph-web