Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB

From	Heiko Stuebner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB
Date	2016-05-12 00:40 +0200
Message-ID	<rxKXn-P8-13@gated-at.bofh.it> (permalink)
References	<rxpSW-52V-11@gated-at.bofh.it> <rxDMf-1Nm-41@gated-at.bofh.it> <rxKXn-P8-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Mittwoch, 11. Mai 2016, 15:32:33 schrieb Brian Norris:
> On Wed, May 11, 2016 at 04:51:58PM +0200, Heiko Stuebner wrote:
> > Hi Brian,
> > 
> > Am Dienstag, 10. Mai 2016, 17:02:55 schrieb Brian Norris:
> > > The 'mmc-hs400-enhanced-strobe' property has been acked by Rob
> > > Herring,
> > > though it's still not merged.
> > 
> > The commit message should describe the actual change not the volatile
> > environment surrounding it :-) .
> > 
> > When I apply this patch the property-binding will have made it into a
> > maintainer-tree so is not valid anymore then. That is more material for
> > the "comment-section" below the "---"
> 
> Of course. I think I just felt guilty without a commit message :)

I really prefer a (even simple) message being there - although I'm not as 
strict as Greg and Felipe ;-) , and in cases like this I think something 
like "enable the newly added emmc node on the rk3399 evaluation board" 
should be sufficient.


Heiko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Brian Norris <briannorris@chromium.org> - 2016-05-11 02:10 +0200
  Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-11 03:10 +0200
    Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Brian Norris <briannorris@chromium.org> - 2016-05-11 03:20 +0200
  Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Heiko Stuebner <heiko@sntech.de> - 2016-05-11 17:00 +0200
    Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Brian Norris <briannorris@chromium.org> - 2016-05-12 00:40 +0200
      Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Heiko Stuebner <heiko@sntech.de> - 2016-05-12 00:40 +0200

csiph-web