Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1399543
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver |
| Date | 2016-05-12 00:20 +0200 |
| Message-ID | <rxKE2-E3-5@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <rvWzE-5nU-11@gated-at.bofh.it> <rwDbz-5aj-7@gated-at.bofh.it> <rx20i-6qo-9@gated-at.bofh.it> <rx20i-6qo-19@gated-at.bofh.it> <rxlmh-zy-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 05/10, Priit Laes wrote:
> On Mon, 2016-05-09 at 15:39 -0700, Stephen Boyd wrote:
> > On 05/09, Stephen Boyd wrote:
> > >
> > >
> > > Ok I applied this one to clk-next.
> > >
> > And I squashed this in to silence the following checker warning.
> >
> > drivers/clk/sunxi/clk-sun4i-display.c:110:33: warning: Variable
> > length array is used.
> >
> > ---8<---
> > diff --git a/drivers/clk/sunxi/clk-sun4i-display.c
> > b/drivers/clk/sunxi/clk-sun4i-display.c
> > index f02e250e64ed..f8ff6c4a5633 100644
> > --- a/drivers/clk/sunxi/clk-sun4i-display.c
> > +++ b/drivers/clk/sunxi/clk-sun4i-display.c
> > @@ -107,7 +107,7 @@ static int sun4i_a10_display_reset_xlate(struct
> > reset_controller_dev *rcdev,
> > static void __init sun4i_a10_display_init(struct device_node *node,
> > const struct
> > sun4i_a10_display_clk_data *data)
> > {
> > - const char *parents[data->parents];
> > + const char *parents[4];
>
> This change breaks at least de_[bf]e clocks which have 3 clock parents.
>
I just used the largest data->parents number, which was 4. How
does that break anything?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Stephen Boyd <sboyd@codeaurora.org> - 2016-05-07 00:40 +0200
Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-08 22:10 +0200
Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Stephen Boyd <sboyd@codeaurora.org> - 2016-05-10 00:40 +0200
Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Stephen Boyd <sboyd@codeaurora.org> - 2016-05-10 00:40 +0200
Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-10 08:40 +0200
Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Stephen Boyd <sboyd@codeaurora.org> - 2016-05-12 00:20 +0200
Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Priit Laes <plaes@plaes.org> - 2016-05-10 21:20 +0200
Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Stephen Boyd <sboyd@codeaurora.org> - 2016-05-12 00:20 +0200
Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Priit Laes <plaes@plaes.org> - 2016-05-12 05:40 +0200
Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-12 09:00 +0200
Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-12 10:40 +0200
Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Stephen Boyd <sboyd@codeaurora.org> - 2016-05-12 23:50 +0200
csiph-web