Re: [RFC PATCH 2/8] KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver 3]

From	Mat Martineau <mathew.j.martineau@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 2/8] KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver 3]
Date	2016-05-12 00:20 +0200
Message-ID	<rxKE2-E3-17@gated-at.bofh.it> (permalink)
References	<rxDjb-1to-3@gated-at.bofh.it> <rxDjb-1to-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 11 May 2016, David Howells wrote:

> diff --git a/Documentation/security/keys.txt b/Documentation/security/keys.txt
> index ca72b70a24b9..01c2ae28a8c0 100644
> --- a/Documentation/security/keys.txt
> +++ b/Documentation/security/keys.txt
> +     If the key needs to be unlocked with a password, a logon-type key that
> +     holds the password may be given as the password argument
...
> +     If the key must be unlocked with a password before it can be used,
> +     password_id should point to a logon-type key that holds this.

It should be noted that the password_id should be 0 if no password is to 
be used.

> diff --git a/security/keys/keyctl_pkey.c b/security/keys/keyctl_pkey.c
> new file mode 100644
> index 000000000000..7f51db984aaa
> --- /dev/null
> +++ b/security/keys/keyctl_pkey.c
> +long keyctl_pkey_e_d_s(int op,
...
> +	ret = params.key->type->asym_eds_op(&params, in, out);

Need to check for NULL asym_eds_op before calling.


Regards,

--
Mat Martineau
Intel OTC

Thread

[RFC PATCH 0/8] KEYS: keyctl operations for asymmetric keys [ver 3] David Howells <dhowells@redhat.com> - 2016-05-11 16:30 +0200
  [RFC PATCH 3/8] KEYS: Provide missing asymmetric key subops for new  key type ops [ver 3] David Howells <dhowells@redhat.com> - 2016-05-11 16:30 +0200
  [RFC PATCH 2/8] KEYS: Provide keyctls to drive the new key type ops  for asymmetric keys [ver 3] David Howells <dhowells@redhat.com> - 2016-05-11 16:30 +0200
    Re: [RFC PATCH 2/8] KEYS: Provide keyctls to drive the new key type  ops for asymmetric keys [ver 3] Mat Martineau <mathew.j.martineau@linux.intel.com> - 2016-05-12 00:20 +0200
      Re: [RFC PATCH 2/8] KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver 3] David Howells <dhowells@redhat.com> - 2016-05-12 12:20 +0200
      Re: [RFC PATCH 2/8] KEYS: Provide keyctls to drive the new key type  ops for asymmetric keys [ver 3] David Woodhouse <dwmw2@infradead.org> - 2016-05-12 13:10 +0200
  [RFC PATCH 7/8] KEYS: Implement encrypt,  decrypt and sign for software asymmetric key [ver 3] David Howells <dhowells@redhat.com> - 2016-05-11 16:30 +0200
  [RFC PATCH 5/8] KEYS: Provide software public key query function  [ver 3] David Howells <dhowells@redhat.com> - 2016-05-11 16:30 +0200
    Re: [RFC PATCH 5/8] KEYS: Provide software public key query function  [ver 3] Mat Martineau <mathew.j.martineau@linux.intel.com> - 2016-05-12 02:00 +0200
      Re: [RFC PATCH 5/8] KEYS: Provide software public key query function  [ver 3] Tadeusz Struk <tstruk@gmail.com> - 2016-05-12 02:20 +0200
      Re: [RFC PATCH 5/8] KEYS: Provide software public key query function [ver 3] David Howells <dhowells@redhat.com> - 2016-05-12 12:20 +0200
        Re: [RFC PATCH 5/8] KEYS: Provide software public key query function  [ver 3] Mat Martineau <mathew.j.martineau@linux.intel.com> - 2016-05-12 19:10 +0200
  [RFC PATCH 1/8] KEYS: Provide key type operations for asymmetric  key ops [ver 3] David Howells <dhowells@redhat.com> - 2016-05-11 16:30 +0200
  [RFC PATCH 8/8] KEYS: Implement PKCS#8 RSA Private Key parser [ver  3] David Howells <dhowells@redhat.com> - 2016-05-11 16:30 +0200
    Re: [RFC PATCH 8/8] KEYS: Implement PKCS#8 RSA Private Key parser  [ver 3] David Woodhouse <dwmw2@infradead.org> - 2016-05-11 21:20 +0200
    Re: [RFC PATCH 8/8] KEYS: Implement PKCS#8 RSA Private Key parser  [ver 3] Mat Martineau <mathew.j.martineau@linux.intel.com> - 2016-05-12 02:20 +0200
      Re: [RFC PATCH 8/8] KEYS: Implement PKCS#8 RSA Private Key parser [ver 3] David Howells <dhowells@redhat.com> - 2016-05-12 12:30 +0200
  [RFC PATCH 4/8] KEYS: Make the X.509 and PKCS7 parsers supply the  sig encoding type [ver 3] David Howells <dhowells@redhat.com> - 2016-05-11 16:30 +0200
  [RFC PATCH 6/8] KEYS: Allow the public_key struct to hold a private  key [ver 3] David Howells <dhowells@redhat.com> - 2016-05-11 16:30 +0200

csiph-web