Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399438

Re: [PATCH] platform/chrome: cros_ec_lightbar - use name instead of ID to hide lightbar attributes

Show all headers | View raw

On Tue, Mar 08, 2016 at 10:36:24PM -0600, Clinton Sprain wrote:
> Lightbar attributes are hidden if the ID of the device is not 0
> (the assumption being that 0 = cros_ec = might have a lightbar,
> 1 = cros_pd = hide); however, sometimes these devices get IDs 1
> and 2 (or something else) instead of IDs 0 and 1. This prevents
> the lightbar attributes from appearing when they should.
> 
> Proposed change is to instead check whether the name assigned to
> the device is CROS_EC_DEV_NAME (true for cros_ec, false for cros_pd).
> 
> Signed-off-by: Clinton Sprain <clintonsprain@gmail.com>

Hm. I wonder why we need to check at all, given that the lightbar version check
is just going to fail later anyway.

Either way, applied with some manual fixups due to surrounding changes.
Apologies for the long delay here.


-Olof

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] platform/chrome: cros_ec_lightbar - use name instead of  ID to hide lightbar attributes Olof Johansson <olof@lixom.net> - 2016-05-11 21:10 +0200

csiph-web