Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1399058
| From | William Breathitt Gray <vilhelm.gray@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] watchdog: ebc-c384_wdt: Simplify ebc_c384_wdt_start timeout computation |
| Date | 2016-05-11 15:10 +0200 |
| Message-ID | <rxC3M-to-9@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The ebc_c384_wdt_set_timeout function already rounds up timeout values greater than 255 to a multiple of 60, so there is no need to round again in the ebc_c384_wdt_start function; a timeout value greater than 255 in ebc_c384_wdt_start will divide cleanly by 60. Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/watchdog/ebc-c384_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c index 77fda0b..948e687 100644 --- a/drivers/watchdog/ebc-c384_wdt.c +++ b/drivers/watchdog/ebc-c384_wdt.c @@ -51,7 +51,7 @@ static int ebc_c384_wdt_start(struct watchdog_device *wdev) /* resolution is in minutes for timeouts greater than 255 seconds */ if (t > 255) - t = DIV_ROUND_UP(t, 60); + t /= 60; outb(t, PET_ADDR); -- 2.7.3
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] watchdog: ebc-c384_wdt: Simplify ebc_c384_wdt_start timeout computation William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-05-11 15:10 +0200
Re: [PATCH] watchdog: ebc-c384_wdt: Simplify ebc_c384_wdt_start timeout computation Guenter Roeck <linux@roeck-us.net> - 2016-05-11 15:50 +0200
Re: [PATCH] watchdog: ebc-c384_wdt: Simplify ebc_c384_wdt_start timeout computation William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-05-11 16:00 +0200
csiph-web