Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399045

[PATCH] cgroup: remove an unused variable

Show all headers | View raw

The newly introduced cgroup_show_path has an extraneous variable
that gcc warns about:

kernel/cgroup.c: In function 'cgroup_show_path':
kernel/cgroup.c:1634:15: error: unused variable 'ret' [-Werror=unused-variable]
  int len = 0, ret = 0;

This must have been left over from a previous version that was
changed before it got committed. I checked the function and
found that two other variables in the same function have an
extraneous initialization, presumably another artifact from
the same rework.

This patch removes the useless warning and the extra initializations.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/cgroup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index afea39eb7649..29ead73d2536 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1631,8 +1631,8 @@ static int rebind_subsystems(struct cgroup_root *dst_root, u16 ss_mask)
 static int cgroup_show_path(struct seq_file *sf, struct kernfs_node *kf_node,
 			    struct kernfs_root *kf_root)
 {
-	int len = 0, ret = 0;
-	char *buf = NULL;
+	int len;
+	char *buf;
 	struct cgroup_root *kf_cgroot = cgroup_root_from_kf(kf_root);
 	struct cgroup *ns_cgroup;
 
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] cgroup: remove an unused variable Arnd Bergmann <arnd@arndb.de> - 2016-05-11 15:00 +0200
  Re: [PATCH] cgroup: remove an unused variable "Serge E. Hallyn" <serge@hallyn.com> - 2016-05-11 16:30 +0200

csiph-web