Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1398954

Re: [PATCH V7 03/11] pci, of: Move the PCI I/O space management to PCI core code.

Show all headers | View raw

On Wednesday 11 May 2016 09:36:58 Tomasz Nowicki wrote:
> >
> > I understand that this moves code around, but those in-function
> > #ifdefs aren't nice.  Any chance to get rid of them but putting whole
> > functions under the #ifdef?
> >
> 
> This is a __weak implementation, so assuming I would move #ifdef out of 
> function I need to provide another empty __weak stub. I do not know 
> which solution is more ugly. In any case we can do that cleanup separately.
> 

I'd vote for just dropping the __weak here, given that there is no
non-weak implementation. If we end up needing to override this for
some architecture or host bridge in the future, we can think about how
to best do that then.

I agree that should be a separate patch, this one should only move
code from one file to another.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V7 00/11] Support for generic ACPI based PCI host controller Tomasz Nowicki <tn@semihalf.com> - 2016-05-10 17:30 +0200
  [PATCH V7 08/11] pci, acpi: Support for ACPI based generic PCI host controller Tomasz Nowicki <tn@semihalf.com> - 2016-05-10 17:30 +0200
    Re: [PATCH V7 08/11] pci, acpi: Support for ACPI based generic PCI  host controller "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-10 20:00 +0200
    Re: [PATCH V7 08/11] pci, acpi: Support for ACPI based generic PCI  host controller "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-10 20:20 +0200
  [PATCH V7 05/11] acpi, pci: Support IO resources when parsing PCI host bridge resources. Tomasz Nowicki <tn@semihalf.com> - 2016-05-10 17:30 +0200
    Re: [PATCH V7 05/11] acpi, pci: Support IO resources when parsing PCI  host bridge resources. "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-10 20:30 +0200
      Re: [PATCH V7 05/11] acpi, pci: Support IO resources when parsing PCI  host bridge resources. Tomasz Nowicki <tn@semihalf.com> - 2016-05-11 09:40 +0200
  [PATCH V7 01/11] PCI: Provide common functions for ECAM mapping Tomasz Nowicki <tn@semihalf.com> - 2016-05-10 17:30 +0200
  [PATCH V7 03/11] pci, of: Move the PCI I/O space management to PCI core code. Tomasz Nowicki <tn@semihalf.com> - 2016-05-10 17:30 +0200
    Re: [PATCH V7 03/11] pci, of: Move the PCI I/O space management to  PCI core code. "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-10 20:00 +0200
      Re: [PATCH V7 03/11] pci, of: Move the PCI I/O space management to  PCI core code. Tomasz Nowicki <tn@semihalf.com> - 2016-05-11 09:40 +0200
        Re: [PATCH V7 03/11] pci, of: Move the PCI I/O space management to PCI core code. Arnd Bergmann <arnd@arndb.de> - 2016-05-11 13:10 +0200
  [PATCH V7 11/11] arm64, pci, acpi: Start using ACPI based PCI host controller driver for ARM64. Tomasz Nowicki <tn@semihalf.com> - 2016-05-10 17:30 +0200
  [PATCH V7 04/11] pci: Add new function to unmap IO resources. Tomasz Nowicki <tn@semihalf.com> - 2016-05-10 17:30 +0200
  [PATCH V7 02/11] PCI: generic, thunder: update to use generic ECAM API Tomasz Nowicki <tn@semihalf.com> - 2016-05-10 17:30 +0200
  RE: [PATCH V7 00/11] Support for generic ACPI based PCI host  controller Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-05-11 12:50 +0200
    Re: [PATCH V7 00/11] Support for generic ACPI based PCI host  controller Tomasz Nowicki <tn@semihalf.com> - 2016-05-11 13:10 +0200
      RE: [PATCH V7 00/11] Support for generic ACPI based PCI host  controller Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-05-11 15:00 +0200

csiph-web