Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1398977

Re: [PATCH] mm-kasan-initial-memory-quarantine-implementation-v8-fix

Show all headers | View raw

On 05/11/2016 01:18 PM, Alexander Potapenko wrote:
> On Tue, May 10, 2016 at 3:38 PM, Andrey Ryabinin
> <aryabinin@virtuozzo.com> wrote:
>>  * Fix comment styles,
>  yDid you remove the comments from include/linux/kasan.h because they
> were put inconsistently, or was there any other reason?

We usually comment functions near definition, not declarations.
If you like, put comment back. Just place it near definition.

>>  * Get rid of some ifdefs
> Thanks!
>>  * Revert needless functions renames in quarantine patch
> I believe right now the names are somewhat obscure. I agree however
> the change should be done in a separate patch.

Besides that, I didn't like the fact that you made names longer and exceeded
80-char limit in some places.

>>  * Remove needless local_irq_save()/restore() in per_cpu_remove_cache()
> Ack
>>  * Add new 'struct qlist_node' instead of 'void **' types. This makes
>>    code a bit more redable.
> Nice, thank you!
> 
> How do I incorporate your changes? Is it ok if I merge it with the
> next version of my patch and add a "Signed-off-by: Andrey Ryabinin
> <aryabinin@virtuozzo.com>" line to the description?
> 

Ok, but I don't think that this is matters. Andrew will just craft a diff patch
on top of the current code anyways.
Or you can make such diff by yourself and send it, it's easier to review, after all.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm-kasan-initial-memory-quarantine-implementation-v8-fix Andrey Ryabinin <aryabinin@virtuozzo.com> - 2016-05-10 15:40 +0200
  Re: [PATCH] mm-kasan-initial-memory-quarantine-implementation-v8-fix Alexander Potapenko <glider@google.com> - 2016-05-11 12:20 +0200
    Re: [PATCH] mm-kasan-initial-memory-quarantine-implementation-v8-fix Andrey Ryabinin <aryabinin@virtuozzo.com> - 2016-05-11 13:50 +0200
      Re: [PATCH] mm-kasan-initial-memory-quarantine-implementation-v8-fix Alexander Potapenko <glider@google.com> - 2016-05-11 16:40 +0200
        Re: [PATCH] mm-kasan-initial-memory-quarantine-implementation-v8-fix Alexander Potapenko <glider@google.com> - 2016-05-11 17:40 +0200

csiph-web