Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1397698

Re: [PATCH v2 04/22] clk: samsung: exynos5410: Provide fin_pll external fixed clock

Show all headers | View raw

On 05/09/2016 10:19 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 05/08/2016 03:05 PM, Krzysztof Kozlowski wrote:
>> Just like clock driver for Exynos542x/5800, provide the fixed clock here
>> so the clock bindings and their consumers would be consistent and
>> similar.
>>
>> However a clock named "fin_pll" is already provided by generic
>> fixed-clock and it is both referenced in the clock driver (by name) and
>> in DT (by phandle). To make the transition smooth, first introduce the
>> new external fixed clock here under temporary, different name and switch
>> internal users to it.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
> 
> [snip]
> 
>>  
>> +/* Same as in Exynos5420 */
>> +static const struct of_device_id ext_clk_match[] __initconst = {
>> +	{ .compatible = "samsung,exynos5420-oscclk", .data = (void *)0, },
> 
> Since using designated initializers, I was about to say that there is no need
> to explicitly set .data to 0 since omitted fields are implicitly initialized...
> 
>> +	{ },
>> +};
>> +
>>  /* register exynos5410 clocks */
>>  static void __init exynos5410_clk_init(struct device_node *np)
>>  {
>> @@ -192,6 +204,10 @@ static void __init exynos5410_clk_init(struct device_node *np)
>>  
>>  	ctx = samsung_clk_init(np, reg_base, CLK_NR_CLKS);
>>  
>> +	samsung_clk_of_register_fixed_ext(ctx, exynos5x_fixed_rate_ext_clks,
>> +			ARRAY_SIZE(exynos5x_fixed_rate_ext_clks),
>> +			ext_clk_match);
>> +
> 
> ... but then I noticed that .data is used as exynos5x_fixed_rate_ext_clks
> array index in samsung_clk_of_register_fixed_ext(). So makes sense to set
> it explicitly to make the intent clear.

Yes, that is the intention here. The '(void *)0' is a hint that clock
needs frequency from DT.

Thanks for review,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/22] ARM: dts: exynos: Add initial support for Odroid XU Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:10 +0200
  [PATCH v2 21/22] ARM: dts: exynos: Add USB to Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:10 +0200
  [PATCH v2 05/22] ARM: dts: exynos: Switch MCT node to a new fin_pll clock Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:10 +0200
  [PATCH v2 06/22] ARM: dts: exynos: Remove old fixed-clock provider on SMDK5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:10 +0200
    Re: [PATCH v2 06/22] ARM: dts: exynos: Remove old fixed-clock  provider on SMDK5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-09 22:30 +0200
      Re: [PATCH v2 06/22] ARM: dts: exynos: Remove old fixed-clock provider  on SMDK5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-10 07:30 +0200
  [PATCH v2 15/22] ARM: dts: exynos: Use phandle to get parent node in exynos5250-snow Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:10 +0200
    Re: [PATCH v2 15/22] ARM: dts: exynos: Use phandle to get parent node  in exynos5250-snow Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-09 23:40 +0200
  [PATCH v2 03/22] ARM: dts: exynos: Add fin_pll node for clock driver Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:10 +0200
  [PATCH v2 01/22] dt-bindings: clock: Add license and reformat Exynos5410 clock IDs Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:10 +0200
    Re: [PATCH v2 01/22] dt-bindings: clock: Add license and reformat  Exynos5410 clock IDs Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-09 21:40 +0200
  [PATCH v2 20/22] ARM: dts: exynos: Move common Exynos5410/542x/5800 nodes to new DTSI Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:10 +0200
    Re: [PATCH v2 20/22] ARM: dts: exynos: Move common  Exynos5410/542x/5800 nodes to new DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-10 00:00 +0200
      Re: [PATCH v2 20/22] ARM: dts: exynos: Move common  Exynos5410/542x/5800 nodes to new DTSI Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-10 07:40 +0200
        Re: [PATCH v2 20/22] ARM: dts: exynos: Move common  Exynos5410/542x/5800 nodes to new DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-10 15:00 +0200
  [PATCH v2 22/22] ARM: dts: exynos: Add initial support for Odroid XU board Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:10 +0200
    Re: [PATCH v2 22/22] ARM: dts: exynos: Add initial support for  Odroid XU board Rob Herring <robh@kernel.org> - 2016-05-09 22:10 +0200
    Re: [PATCH v2 22/22] ARM: dts: exynos: Add initial support for Odroid  XU board Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-10 00:10 +0200
      Re: [PATCH v2 22/22] ARM: dts: exynos: Add initial support for Odroid  XU board Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-10 07:40 +0200
  [PATCH v2 04/22] clk: samsung: exynos5410: Provide fin_pll external fixed clock Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:20 +0200
    Re: [PATCH v2 04/22] clk: samsung: exynos5410: Provide fin_pll  external fixed clock Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-09 22:30 +0200
      Re: [PATCH v2 04/22] clk: samsung: exynos5410: Provide fin_pll  external fixed clock Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-10 07:30 +0200
  [PATCH v2 09/22] ARM: dts: exynos: Re-order alphabetically Exynos5420 SD0/SD1 pinctrl nodes Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:20 +0200
  [PATCH v2 11/22] ARM: dts: exynos: Configure Exynos5410 pinctrl for eMMC and SD card Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:20 +0200
  [PATCH v2 14/22] ARM: dts: exynos: Prepare for inclusion of exynos5.dtsi in exynos5410.dtsi Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:20 +0200
  [PATCH v2 02/22] dt-bindings: clock: Add PWM and USB clock IDs to Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-08 21:20 +0200
    Re: [PATCH v2 02/22] dt-bindings: clock: Add PWM and USB clock IDs to  Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-09 21:50 +0200
  Re: [PATCH v2 16/22] ARM: dts: exynos: Move Exynos5250 and Exynos5420  nodes under soc Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-09 23:40 +0200
  Re: [PATCH v2 00/22] ARM: dts: exynos: Add initial support for Odroid  XU Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-10 00:10 +0200
    Re: [PATCH v2 00/22] ARM: dts: exynos: Add initial support for Odroid  XU Krzysztof Kozlowski <krzk@kernel.org> - 2016-05-10 07:20 +0200
      Re: [PATCH v2 00/22] ARM: dts: exynos: Add initial support for Odroid  XU Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-10 16:10 +0200
  Re: [PATCH v2 00/22] ARM: dts: exynos: Add initial support for  Odroid XU Stephen Boyd <sboyd@codeaurora.org> - 2016-05-10 00:10 +0200

csiph-web