Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1397611

[PATCH 2/3] clk: bcm2835: Mark GPIO clocks enabled at boot as critical.

From Eric Anholt <eric@anholt.net>
Newsgroups linux.kernel
Subject [PATCH 2/3] clk: bcm2835: Mark GPIO clocks enabled at boot as critical.
Date 2016-05-10 03:10 +0200
Message-ID <rx4ls-tZ-7@gated-at.bofh.it> (permalink)
References <rx4ls-tZ-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


These divide off of PLLD_PER and are used for the ethernet and wifi
PHYs source PLLs.  Neither of them is currently represented by a phy
device that would grab the clock for us.

This keeps other drivers from killing the networking PHYs when they
disable their own clocks and trigger PLLD_PER's refcount going to 0.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/clk/bcm/clk-bcm2835.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index d9db03cb3fd8..1091012ecec6 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk/bcm/clk-bcm2835.c
@@ -1708,13 +1708,15 @@ static const struct bcm2835_clk_desc clk_desc_array[] = {
 		.div_reg = CM_GP1DIV,
 		.int_bits = 12,
 		.frac_bits = 12,
+		.flags = CLK_IS_CRITICAL,
 		.is_mash_clock = true),
 	[BCM2835_CLOCK_GP2]	= REGISTER_PER_CLK(
 		.name = "gp2",
 		.ctl_reg = CM_GP2CTL,
 		.div_reg = CM_GP2DIV,
 		.int_bits = 12,
-		.frac_bits = 12),
+		.frac_bits = 12,
+		.flags = CLK_IS_CRITICAL),
 
 	/* HDMI state machine */
 	[BCM2835_CLOCK_HSM]	= REGISTER_PER_CLK(
-- 
2.8.0.rc3

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] clk: bcm2835: critical clocks and parent selection Eric Anholt <eric@anholt.net> - 2016-05-10 03:10 +0200
  [PATCH 2/3] clk: bcm2835: Mark GPIO clocks enabled at boot as critical. Eric Anholt <eric@anholt.net> - 2016-05-10 03:10 +0200
  [PATCH 3/3] clk: bcm2835: Skip PLLC clocks when deciding on a new clock parent Eric Anholt <eric@anholt.net> - 2016-05-10 03:10 +0200
    Re: [PATCH 3/3] clk: bcm2835: Skip PLLC clocks when deciding on a  new clock parent Stephen Boyd <sboyd@codeaurora.org> - 2016-05-12 01:00 +0200
      Re: [PATCH 3/3] clk: bcm2835: Skip PLLC clocks when deciding on a new clock parent Eric Anholt <eric@anholt.net> - 2016-05-12 03:50 +0200
  Re: [PATCH 0/3] clk: bcm2835: critical clocks and parent selection Martin Sperl <kernel@martin.sperl.org> - 2016-05-10 12:40 +0200
    Re: [PATCH 0/3] clk: bcm2835: critical clocks and parent selection Eric Anholt <eric@anholt.net> - 2016-05-10 19:40 +0200
      Re: [PATCH 0/3] clk: bcm2835: critical clocks and parent selection Martin Sperl <kernel@martin.sperl.org> - 2016-05-10 22:00 +0200
        Re: [PATCH 0/3] clk: bcm2835: critical clocks and parent selection Martin Sperl <kernel@martin.sperl.org> - 2016-05-11 10:30 +0200
          Re: [PATCH 0/3] clk: bcm2835: critical clocks and parent selection Martin Sperl <kernel@martin.sperl.org> - 2016-05-11 18:10 +0200

csiph-web