Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1397530

Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset

Show all headers | View raw

On Monday, May 09, 2016 04:53:16 PM Steve Muckle wrote:
> On Sat, May 07, 2016 at 08:30:51AM +0200, Ingo Molnar wrote:
> > 
> > * Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > On Fri, May 06, 2016 at 02:58:43PM +0200, Rafael J. Wysocki wrote:
> > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > > 
> > > > Commit 34e2c555f3e1 (cpufreq: Add mechanism for registering utilization
> > > > update callbacks) overlooked the fact that update_load_avg(), where
> > > > CFS invokes cpufreq utilization update hooks, becomes an empty stub for
> > > > CONFIG_SMP unset.  In consequence, if CONFIG_SMP is not set, cpufreq
> > > > governors are never invoked from CFS and they do not have a chance to
> > > > evaluate CPU performace levels and update them often enough.  Needless
> > > > to say, things don't work as expected then.
> > > > 
> > > > Fix the problem by making the !CONFIG_SMP stub of update_load_avg()
> > > > invoke cpufreq update hooks too.
> > > > 
> > > > Fixes: 34e2c555f3e1 (cpufreq: Add mechanism for registering utilization update callbacks)
> > > > Reported-by: Steve Muckle <steve.muckle@linaro.org>
> > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > 
> > > Rafael; feel free to push this through the pm tree.
> > > 
> > > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > 
> > I already have it in sched/urgent.
> 
> Looks like this just missed 4.6-rc7 and the release email for
> that doesn't suggest an rc8, as it stands...

But the final 4.6 will be released on Sunday or so and there are a few days
left still.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-06 15:00 +0200
  Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset Steve Muckle <steve.muckle@linaro.org> - 2016-05-06 21:10 +0200
    Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-06 21:40 +0200
  Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset Peter Zijlstra <peterz@infradead.org> - 2016-05-07 08:20 +0200
    Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset Ingo Molnar <mingo@kernel.org> - 2016-05-07 08:40 +0200
      Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset Peter Zijlstra <peterz@infradead.org> - 2016-05-09 10:40 +0200
      Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-10 02:00 +0200
        Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset Ingo Molnar <mingo@kernel.org> - 2016-05-10 10:20 +0200
      Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset Steve Muckle <steve.muckle@linaro.org> - 2016-05-10 02:00 +0200
  [tip:sched/urgent] sched/fair: Fix !CONFIG_SMP kernel cpufreq  governor breakage "tip-bot for Rafael J. Wysocki" <tipbot@zytor.com> - 2016-05-07 08:40 +0200

csiph-web