Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1397517
| From | Yu-cheng Yu <yu-cheng.yu@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 11/13] x86/xsaves: Add WARN_ON_FPU() when a disabled xstate component offset is requested for a compacted format |
| Date | 2016-05-10 01:50 +0200 |
| Message-ID | <rx362-7sX-19@gated-at.bofh.it> (permalink) |
| References | <rx0rx-4yi-11@gated-at.bofh.it> <rx0rz-4yi-59@gated-at.bofh.it> <rx2Wm-7n5-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, May 09, 2016 at 04:31:18PM -0700, Dave Hansen wrote:
> On 05/09/2016 01:46 PM, Yu-cheng Yu wrote:
> > Add a warning in case a disabled (not existing) xstate component offset
> > is requested.
> ...
> > diff --git a/arch/x86/kernel/fpu/xstate.c b/arch/x86/kernel/fpu/xstate.c
> > index 350814c..2e6dbfe 100644
> > --- a/arch/x86/kernel/fpu/xstate.c
> > +++ b/arch/x86/kernel/fpu/xstate.c
> > @@ -756,6 +756,7 @@ void *__raw_xsave_addr(struct xregs_state *xsave, int xstate_feature_mask)
> > {
> > int feature_nr = fls64(xstate_feature_mask) - 1;
> >
> > + WARN_ON_FPU(using_compacted_format() && !xfeature_enabled(feature_nr));
> > return (void *)xsave + xstate_comp_offsets[feature_nr];
> > }
>
> Why the using_compacted_format()? Shouldn't this be an error, regardless.
If the kernel is not using compacted format, I can get a component offset, no?
>
> Also, what is xstate_comp_offsets[feature_nr] in this case? Isn't it
> -1? Should we be returning NULL along with WARN()ing?
NULL makes sense. I will change it.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 11/13] x86/xsaves: Add WARN_ON_FPU() when a disabled xstate component offset is requested for a compacted format Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-05-09 23:00 +0200
Re: [PATCH v5 11/13] x86/xsaves: Add WARN_ON_FPU() when a disabled xstate component offset is requested for a compacted format Dave Hansen <dave.hansen@linux.intel.com> - 2016-05-10 01:40 +0200
Re: [PATCH v5 11/13] x86/xsaves: Add WARN_ON_FPU() when a disabled xstate component offset is requested for a compacted format Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-05-10 01:50 +0200
Re: [PATCH v5 11/13] x86/xsaves: Add WARN_ON_FPU() when a disabled xstate component offset is requested for a compacted format Dave Hansen <dave.hansen@linux.intel.com> - 2016-05-10 02:00 +0200
csiph-web