Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1396439

RE: [PATCH] debugobjects: insulate non-fixup logic related to static obj from fixup callbacks

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject RE: [PATCH] debugobjects: insulate non-fixup logic related to static obj from fixup callbacks
Date 2016-05-08 18:20 +0200
Message-ID <rwzB0-1LG-13@gated-at.bofh.it> (permalink)
References <rvXm2-6qk-3@gated-at.bofh.it> <rw5MB-6pI-1@gated-at.bofh.it> <rwrDr-2ET-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sun, 8 May 2016, Du, Changbin wrote:
> > From: Thomas Gleixner [mailto:tglx@linutronix.de]
> > >  		raw_spin_unlock_irqrestore(&db->lock, flags);
> > >  		/*
> > > -		 * Maybe the object is static.  Let the type specific
> > > +		 * Maybe the object is static. Let the type specific
> > >  		 * code decide what to do.
> > 
> > Instead of doing white space changes you really want to explain the logic
> > here.
> > 
> Comments is in following code.

Well. It's a comment, but the code you replace has better explanations about
statically initialized objects. This should move here.
 
Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] debugobjects: insulate non-fixup logic related to static obj from fixup callbacks changbin.du@intel.com - 2016-05-07 01:30 +0200
  Re: [PATCH] debugobjects: insulate non-fixup logic related to static  obj from fixup callbacks kbuild test robot <lkp@intel.com> - 2016-05-07 02:20 +0200
  Re: [PATCH] debugobjects: insulate non-fixup logic related to static  obj from fixup callbacks Thomas Gleixner <tglx@linutronix.de> - 2016-05-07 10:30 +0200
    Re: [PATCH] debugobjects: insulate non-fixup logic related to static  obj from fixup callbacks "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-05-07 14:50 +0200
    RE: [PATCH] debugobjects: insulate non-fixup logic related to  static obj from fixup callbacks "Du, Changbin" <changbin.du@intel.com> - 2016-05-08 09:50 +0200
      RE: [PATCH] debugobjects: insulate non-fixup logic related to static  obj from fixup callbacks Thomas Gleixner <tglx@linutronix.de> - 2016-05-08 18:20 +0200
        RE: [PATCH] debugobjects: insulate non-fixup logic related to  static obj from fixup callbacks "Du, Changbin" <changbin.du@intel.com> - 2016-05-09 05:10 +0200
        [PATCH v2] debugobjects: insulate non-fixup logic related to static obj from fixup callbacks changbin.du@intel.com - 2016-05-09 09:20 +0200

csiph-web