Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1396411

[PATCH 1/2] dma-mapping: add __dma_sync_single_for_device()

Path csiph.com!au2pb.net!weretis.net!feeder6.news.weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Newsgroups linux.kernel
Subject [PATCH 1/2] dma-mapping: add __dma_sync_single_for_device()
Date Sun, 08 May 2016 13:20:02 +0200
Message-ID <rwuUG-5Vl-9@gated-at.bofh.it> (permalink)
References <rwuUG-5Vl-11@gated-at.bofh.it>
X-Greylist delayed 466 seconds by postgrey-1.27 at vger.kernel.org; Sun, 08 May 2016 07:10:08 EDT
X-Kth-Auth niso [89.233.230.99]
X-Kth-Mail-From niklas.soderlund+renesas@ragnatech.se
X-Mailer git-send-email 2.8.2
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Content-Transfer-Encoding 8bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 44
Organization linux.* mail to news gateway
X-Original-Cc will.deacon@arm.com, robin.murphy@arm.com, joro@8bytes.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
X-Original-Date Sun, 8 May 2016 12:59:55 +0200
X-Original-Message-ID <1462705196-10857-2-git-send-email-niklas.soderlund+renesas@ragnatech.se>
X-Original-References <1462705196-10857-1-git-send-email-niklas.soderlund+renesas@ragnatech.se>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1396411

Show key headers only | View raw


Some users of the DMA mapping API calls dma_sync_single_for_device()
from the dma_map_single() call path. This will cause false warning
printouts if CONFIG_DMA_API_DEBUG are enabled.

The reason for the warning are that debug_dma_sync_single_for_device()
will be called before debug_dma_map_page() so the new mapping can't be
found and are believed to be invalid. Add __dma_sync_single_for_device()
that don't call into debug_dma_sync_single_for_device() and can be used
in these situations.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 include/linux/dma-mapping.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 9ea9aba..0e4d3a6 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -224,7 +224,7 @@ static inline void dma_sync_single_for_cpu(struct device *dev, dma_addr_t addr,
 	debug_dma_sync_single_for_cpu(dev, addr, size, dir);
 }
 
-static inline void dma_sync_single_for_device(struct device *dev,
+static inline void __dma_sync_single_for_device(struct device *dev,
 					      dma_addr_t addr, size_t size,
 					      enum dma_data_direction dir)
 {
@@ -233,6 +233,13 @@ static inline void dma_sync_single_for_device(struct device *dev,
 	BUG_ON(!valid_dma_direction(dir));
 	if (ops->sync_single_for_device)
 		ops->sync_single_for_device(dev, addr, size, dir);
+}
+
+static inline void dma_sync_single_for_device(struct device *dev,
+					      dma_addr_t addr, size_t size,
+					      enum dma_data_direction dir)
+{
+	__dma_sync_single_for_device(dev, addr, size, dir);
 	debug_dma_sync_single_for_device(dev, addr, size, dir);
 }
 
-- 
2.8.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 1/2] dma-mapping: add __dma_sync_single_for_device() Niklas Söderlund   <niklas.soderlund+renesas@ragnatech.se> - 2016-05-08 13:20 +0200

csiph-web