Re: [PATCH net-next 15/21] net: dsa: mv88e6xxx: factorize VLAN Ethertype

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 15/21] net: dsa: mv88e6xxx: factorize VLAN Ethertype
Date	2016-05-07 23:00 +0200
Message-ID	<rwhuq-jE-5@gated-at.bofh.it> (permalink)
References	<rvVWV-4tS-5@gated-at.bofh.it> <rvW6C-4ZK-35@gated-at.bofh.it> <rvWzE-5nU-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

> On Fri, May 06, 2016 at 05:57:17PM -0400, Vivien Didelot wrote:
>> The 6131 switch models have a Core Tag Type register. Add a
>> MV88E6XXX_FLAG_CORE_TAG_TYPE flag and set the VLAN Ethertype to 0x8100
>> in the shared setup code if it is present.
>
> Do you have any idea what the core tag is?

Core Tag Type is the global register 0x19 present only on 6185 and
similar. It is used when egressing double tagged frames. This value is
also checked when ingressing frames on ports in UseCoreTag mode.

Note that we might remove this flag and setup condition, because 0x8100
is the reset value anyway.

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 00/21] net: dsa: mv88e6xxx: turn into monolithic driver Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-07 00:10 +0200
  [PATCH net-next 13/21] net: dsa: mv88e6xxx: factorize global setup Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-07 00:10 +0200
    Re: [PATCH net-next 13/21] net: dsa: mv88e6xxx: factorize global  setup Andrew Lunn <andrew@lunn.ch> - 2016-05-07 00:30 +0200
  [PATCH net-next 15/21] net: dsa: mv88e6xxx: factorize VLAN Ethertype Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-07 00:10 +0200
    Re: [PATCH net-next 15/21] net: dsa: mv88e6xxx: factorize VLAN  Ethertype Andrew Lunn <andrew@lunn.ch> - 2016-05-07 00:40 +0200
      Re: [PATCH net-next 15/21] net: dsa: mv88e6xxx: factorize VLAN Ethertype Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-07 23:00 +0200

csiph-web