Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1396347

Re: [patch 2/2] netxen: reversed condition in netxen_nic_set_link_parameters()

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [patch 2/2] netxen: reversed condition in netxen_nic_set_link_parameters()
Date 2016-05-07 21:20 +0200
Message-ID <rwfVE-7th-7@gated-at.bofh.it> (permalink)
References <rvrvQ-MH-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 5 May 2016 16:19:44 +0300

> My static checker complains that we are using "autoneg" without
> initializing it.  The problem is the ->phy_read() condition is reversed
> so we only set this on error instead of success.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[patch 2/2] netxen: reversed condition in  netxen_nic_set_link_parameters() Dan Carpenter <dan.carpenter@oracle.com> - 2016-05-05 15:30 +0200
  Re: [patch 2/2] netxen: reversed condition in  netxen_nic_set_link_parameters() David Miller <davem@davemloft.net> - 2016-05-07 21:20 +0200

csiph-web