[PATCH net-next v2 15/21] net: dsa: mv88e6131: drop VLAN Ethertype setup

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	[PATCH net-next v2 15/21] net: dsa: mv88e6131: drop VLAN Ethertype setup
Date	2016-05-09 19:30 +0200
Message-ID	<rwXai-1D1-19@gated-at.bofh.it> (permalink)
References	<rwXah-1D1-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The 6131 switch models have a Core Tag Type register. Their setup code
is setting it to 0x8100, which is the reset default.

Drop this specific part which is correctly configured on reset anyway.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 drivers/net/dsa/mv88e6131.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/dsa/mv88e6131.c b/drivers/net/dsa/mv88e6131.c
index d05fc79..1c3b245 100644
--- a/drivers/net/dsa/mv88e6131.c
+++ b/drivers/net/dsa/mv88e6131.c
@@ -65,11 +65,6 @@ static int mv88e6131_setup_global(struct dsa_switch *ds)
 	int ret;
 	u32 reg;
 
-	/* Set the VLAN ethertype to 0x8100. */
-	ret = mv88e6xxx_reg_write(ps, REG_GLOBAL, GLOBAL_CORE_TAG_TYPE, 0x8100);
-	if (ret)
-		return ret;
-
 	/* Disable ARP mirroring, and configure the upstream port as
 	 * the port to which ingress and egress monitor frames are to
 	 * be sent.
-- 
2.8.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH net-next v2 15/21] net: dsa: mv88e6131: drop VLAN Ethertype setup Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-09 19:30 +0200

csiph-web